search

UltimateHackingKeyboard / firmware

Ultimate Hacking Keyboard firmware
Other
418 stars 65 forks source link

Parse keyid abbreviaitons in set keymapAction. #774

Closed kareltucek closed 4 months ago

kareltucek commented 5 months ago

Reported in https://forum.ultimatehackingkeyboard.com/t/temporarily-change-d-to-delete-with-alt-tab-sequence-without-affecting-alt-d/942/3

Steps to reproduce:

mondalaci commented 5 months ago

Previously, I recall replacing numeric key ids with symbols, but it must have been context-dependent. Would you elaborate on it?

For me, set keymapAction.base.d keystroke d is far more intuitive than set keymapAction.base.81 keystroke d, and I'm unsurprised someone makes such an error.

kareltucek commented 5 months ago

Previously, I recall replacing numeric key ids with symbols, but it must have been context-dependent. Would you elaborate on it?

I don't understand?

The trouble clearly is just that I had missed this site when replacing parsing code from a generic integer parsing to key ids. (If that's what you are confused about anyways.)

For me, set keymapAction.base.d keystroke d is far more intuitive than set keymapAction.base.81 keystroke d, and I'm unsurprised someone makes such an error.

It was me who made that "error". And it was not an error - it is correct according to specification. This is not an implementation of a feature request. It is a fix of a bug.

mondalaci commented 4 months ago

Gotcha! Thanks for explaining.