UltimateHackingKeyboard / firmware

Ultimate Hacking Keyboard firmware
Other
410 stars 63 forks source link

Implement config manager. #776

Closed kareltucek closed 1 month ago

kareltucek commented 1 month ago

Moves all configuration to one central place, and thus allows global reset.

This does not reset component states.

mondalaci commented 1 month ago

How should I test this?

What do you mean by "component states"?

kareltucek commented 1 month ago

I mean macro engine state (scheduler state, macro states, possible static variables), mouse key state arrays, and other similar things.

mondalaci commented 1 month ago

How should I test this PR? I'm unsure.

kareltucek commented 1 month ago

Choose a settings that is not a part of the userconfig and does not edit keymap/ledmap in ram. Then write it from a macro (not a macro event). Now save configuration from Agent and test that the setting was resetted.

mondalaci commented 1 month ago

Please provide me with a couple of such example settings.

kareltucek commented 1 month ago

I am not at computer right now. I guess autoRepeatDelay, autoShiftDelay, chordingDelay, secondaryRole.advanced.triggerByPress, stickyModifiers, modifierLayerTrigger, oneShotTimeout may be of that kind, but please check that against Agent.

mondalaci commented 1 month ago

My trackpoint speed settings are disrespected regardless of the module section settings.

kareltucek commented 1 month ago

My trackpoint speed settings are disrespected regardless of the module section settings.

Ouch.

Fixed.