UltraRangers / gauntlet

Gauntlet is a Typescript server template to kick-off your development fast 🔥🔥🔥
https://gauntlet-demo.herokuapp.com
MIT License
3 stars 0 forks source link

Next milestone discussion 🔥 #28

Closed jmaicaaan closed 6 years ago

jmaicaaan commented 6 years ago

What I have on mind right now are these things:

Also, another feature into the list component in the client, that will automatically request to the specified endpoint? 🤔

cc: @john20xdoe @cedrickmandocdoc

jmaicaaan commented 6 years ago

If you agree with the email support, we'll prolly add the reset password support also 🙆‍♂️

john20xdoe commented 6 years ago

+1 for the email. For email support, currently we can limit it to basic notifications. Account-related (important. required):

Subscribed notifications

NOTE: once we enable email, this also involves proper formatting and email headers so that our emails will not be flagged as spam.

BTW, last time I checked. there is a free tier addon for SendMail in Heroku. I still had one in my old app (circa 2015) that allows free sending without a SendMail acct. But last time I created a new app, using the same addon required a new SendMail Account (and registering for a SendMail account nowadays require a short questionnaire for them to verify your website if it is production-grade. I had my new SendMail acct banned when I mentioned I'm still under development.)

Perhaps you can try adding the addon. If the SendMail account gets banned, I'll try to find the credentiials for my old Heroku-related autoaccount that may still be active for dev.

john20xdoe commented 6 years ago

For the CMS support, we could maybe create the client-side from our vue.js template from @jm-4life . Though I',m not sure if we should create a new repo for it or just include it with gauntlet?

john20xdoe commented 6 years ago

Oh wait, nevermind about the vue. We already have angular here, right?

jmaicaaan commented 6 years ago

I'm not sure if we would like to have the subscribed notification part already. But the Account related features is a must 👍

What is the difference between the SendMail you are mentioning and also this SendGrid?

For the CMS, we already have set up the angular here. The vue-template, we could work on it to another repository soon. You could see in our demo site a preview 🥂

john20xdoe commented 6 years ago

Yes, subscriptions are nice-to-have but not required.

Oops, I stand corrected, I do mean SendGrid hahaha. Been awhile since I've used it...

john20xdoe commented 6 years ago

The configuration for email credentials will also be managed similar to the database.. perhaps again via environment variables.

BTW using SendGrid is not required. For basic sending, we can also test just by using Gmail's POP or IMAP credentials. https://support.google.com/mail/answer/7104828?hl=en PRobably using aliases like ultrarangersPLUStestnotifsATgmail.com

jmaicaaan commented 6 years ago

Is there any difference in using SendGrid rather than Gmail?

john20xdoe commented 6 years ago

SendGrid is much more reliable, and better designed to send mass emails (it's been recognized as non-spam, unless of course the actual email has questionable content). For GMail, we can use it for dev purposes only since it is already set up. However, we shouldn't use it for prod since it doesn't look official, plus free GMail has limits for sending mass emails to prevent abuse and spam (unless setup with GSuite), which will sometimes result in random failures when sending. Also, using the Gmail IMAP and POP outside of email clients will raise an alert in your account for "Less secure apps" https://support.google.com/accounts/answer/6010255?hl=en

jmaicaaan commented 6 years ago

Thanks for the info 👍

Let's just wait for @cedrickmandocdoc if he has any thing to suggest in our next milestone beside from the email features!

ghost commented 6 years ago

Yes email support is good. For migrations using Table is good also. For the table that automatically request, it is also good. Let's do this all.

ghost commented 6 years ago

How about we add this on our list:

john20xdoe commented 6 years ago

For CD, we can setup Heroku pipelines (test, staging) in the current Heroku demo app, or maybe the workflows in CircleCI (I don't know how to set up CircleCi for now). Although, I think staging and production is not that important unless we are actually creating a full non-demo app made from gauntlet (the purpose of staging and prod are for other users).

For test env though, it is necessary to run tests, but not unit tests (that is what CircleCI is for). The test env is for integration and UI tests, again of an app implementing gauntlet.

jmaicaaan commented 6 years ago

I think other environments such as staging and prod is not necessary for us to work on. But the test environment is a must.

Summarizing the discussion here is the list of items I have for our next milestone

Some things are not necessary yet. What are yout thoughts? If everything's good, I'll create the issues/tickets for it 🔥

ghost commented 6 years ago

Everything is good to me haha, Lets get this done. And also remember the issue in the provider it causes circular import I guess in the case of entities, repositories etc having exported in index. But I don't know the real issue. I do have a suggestion, putting the entities in common? yeah I just realized right now what you said to me last time about that, that it should be in common is right.

jmaicaaan commented 6 years ago

What have you realized in the entities part? Hmm, that would change again a few things in our structure.

jmaicaaan commented 6 years ago

Anyways, I've added the new tickets both client and server. Here is the new milestone 🔥