search

UltraStar-Deluxe / Play

Free and open source singing game with song editor for desktop, mobile, and smart TV
https://ultrastar-play.com
MIT License
376 stars 68 forks source link

Fix CI build on Android #366

Open achimmihca opened 1 year ago

achimmihca commented 1 year ago

Actual behaviour

The continuous integration build using GitHub Actions fails for the Android target platform. Error message:

2023-01-09T11:27:13.6923522Z DisplayProgressbar: Detect Java Development Kit (JDK)
2023-01-09T11:27:13.9736423Z UnityException: JDK not found
2023-01-09T11:27:13.9737808Z Java Development Kit (JDK) directory is not set or invalid. Please, fix it in Edit / Unity -> Preferences -> External Tools

However, In Preferences -> External Tools the check box is set for JDK installed with Unity (recommended).

Expected behaviour

The CI build should work.

Sadly, this seems to be a Unity bug in recent version. See also https://github.com/game-ci/unity-builder/issues/489

It might be fixed with the next Unity version.

achimmihca commented 1 year ago

I am confused. I did not change the GitHub Actions, but PR #367 seems to be working again. Weird

supernevi commented 1 year ago

since January 10th there is a new release: https://unity.com/releases/editor/whats-new/2022.2.2

maybe this helps out

achimmihca commented 1 year ago

Great! Will upgrade soon

achimmihca commented 1 year ago

Actually it is not fixed. The Android build still fails because "JDK not found"

achimmihca commented 1 year ago

I disabled the Android build for now. It can be re-enabled when the "JDK not found" issue has been solved.

achimmihca commented 4 weeks ago

Needs re-testing whether the issue still occurs with the new Unity version.