search

UltraStar-Deluxe / USDX

The free and open source karaoke singing game UltraStar Deluxe, inspired by Sony SingStar™
https://usdx.eu
GNU General Public License v2.0
832 stars 160 forks source link

[Windows] Program does not have an icon #105

Closed RattleSN4K3 closed 8 years ago

RattleSN4K3 commented 8 years ago

Due to building a console app, the exe file does not have an icon. This results into desktopn icon, start menu entreis etc. not having a valid icon.

basisbit commented 8 years ago

this is not caused by the app being a console app but instead by lazarus 1.6 forgetting about the correct icon. Just before building, open the project settings and reselect the icon file which is in the src folder, then rebuild. Please confirm that this also works for you.

RattleSN4K3 commented 8 years ago

Works. But the project file has to be updated somehow. Such workaround shouldn't be necessary for a clean build.

RattleSN4K3 commented 8 years ago

Seems like the linking part is the problem. Having ultrastardx.rc doesn't link the file properly. With a renamed file it works well.

RattleSN4K3 commented 8 years ago

cf3316dd8bacd12ea709b4e2d87a5ac97dc27f01. Fixes the problem. Removed some unneeded files. The ultrastardx.res in the src folder is still generated everytime, not sure why it isn't created in the output directory. Therefore I also added it to the ignore files.

This also partially reverts changes done by the merge c4fc4aaf35a1c6469f747f50afcbac10be9e3342.

Can anyone test if this is also working on your system or using delphi?

jmfergeau commented 8 years ago

I compiled the latest build recently and i see the icon correctly. It works to me. :)

RattleSN4K3 commented 8 years ago

Thanks for confirming. Closing this issues but marking it as backlog to check comiling with Delphi and others.