UltraStar-Deluxe / USDX

The free and open source karaoke singing game UltraStar Deluxe, inspired by Sony SingStarâ„¢
https://usdx.eu
GNU General Public License v2.0
868 stars 162 forks source link

[Jukebox] option in txt to get the song ignored #420

Open jmfergeau opened 5 years ago

jmfergeau commented 5 years ago

Actual behaviour

For now, absolutely every song plays in jukebox mode. When you have twice the same song (like, the normal one, and the duet version) they both play as two different songs

Steps to reproduce

  1. Have a song with two txt files. A normal song, and the same song in duet mode (with P1 P2 and so on)
  2. Open usdx and start jukebox mode
  3. The two versions of the song are displayed

Details

My suggestion would be to add an option that makes the song being automatically ignored and not displayed in jukebox mode. Maybe with an extra tag inside the txt like #JUKEBOX=false to make it ignored (and having it set as true by default when not present) so songs in duet that has no other version can still play. Or just #NOJUKEBOX

brianch commented 5 years ago

Thanks for the suggestion, haven't checked it yet but doesn't seem like a hard thing to implement.