search

UltraStar-Deluxe / USDX

The free and open source karaoke singing game UltraStar Deluxe, inspired by Sony SingStar™
https://usdx.eu
GNU General Public License v2.0
849 stars 161 forks source link

USDX should check if the song is already in the playlist when adding #448

Open jose1711 opened 5 years ago

jose1711 commented 5 years ago

Actual behaviour

USDX lets user append a song to an existing playlist even when it has already been there

Expected behaviour

USDX should either issue a warning or just silently ignore the request

Steps to reproduce

  1. Go into song browser
  2. M to bring up song menu
  3. Add to playlist
  4. Repeat steps 2 and 3
  5. Exit USDX
  6. Find out that playlist contains the same song twice
basisbit commented 5 years ago

I personally vote against silently ignoring the request because when creating playlists for parties, the creator might want duplicates of currently famous songs. A warning might be helpful, but if there is a warning, there should also exist an option to not show this warning again ;-)

jose1711 commented 5 years ago

creator might want duplicates

you mean to increase chances of being picked (like when you buy many tickets in a lottery)? interesting.. but it sounds to me more like an easter egg than a feature one would use in real world

basisbit commented 5 years ago

I was referring to all these use cases where you don't use random song selection