UltraStar-Deluxe / USDX

The free and open source karaoke singing game UltraStar Deluxe, inspired by Sony SingStarâ„¢
https://usdx.eu
GNU General Public License v2.0
851 stars 161 forks source link

[Possible bug]: Ini.Save; #552

Closed djStolen closed 4 years ago

djStolen commented 4 years ago

Please, do not create duplicate issues

Actual behaviour

Ini.Save; in UMain.pas will be executed and overwrites the .ini even if the .ini exists.

Expected behaviour

already configured .ini should not be overwritten. Unless explicitly needed.

Steps to reproduce

Please supply step-by-step instructions so that anyone with the same environment can reproduce the issue. Whenever you offer a description, imagine yourself in the shoes of someone who has never encountered this problem before and would like to know exactly how to observe it under a given set of conditions. Here is an example:

  1. change .ini
  2. start ultrastardx
  3. check .ini

Details

Provide some additional information:

s09bQ5 commented 4 years ago

USDX will read the existing ini before it saves the new one. It will automatically change only those settings that make no sense on your system, like when the sound device listed in config.ini is no longer available. So, yeah, overwriting the config.ini is correct behavior.

Or do you have problems to run it from a read-only filesystem?

djStolen commented 4 years ago

USDX will read the existing ini before it saves the new one. It will automatically change only those settings that make no sense on your system, like when the sound device listed in config.ini is no longer available. So, yeah, overwriting the config.ini is correct behavior.

Or do you have problems to run it from a read-only filesystem?

It actually overwrites to Borderless, eventhough I explicitly set something else in .ini, for testing purposes.

No issue with read-only, I actually set .ini to readonly so it does not overwrite the mentioned setting.

basisbit commented 4 years ago

It only overwrites invalid configuration. Closing this issue because this is as designed. You can still continue discussing about it here.

djStolen commented 4 years ago

It only overwrites invalid configuration. Closing this issue because this is as designed. You can still continue discussing about it here.

What is invalid in setting in .ini Fullscreen or Window mode?