Closed RattleSN4K3 closed 4 years ago
I'd guess that the headers of Lua 5.3 has some changes that I missed when I tried my best at porting the fpc lua 5.1 headers to lua 5.2 and 5.3... I am very busy currently but will try to find someone who could take a look at that.
got some feedback from an arch-linux user: installed ultrastardx-git from the aur. it uses lua 5.3.3 ("checking version of lua... [5.3.3]") and plugins are detected and work just fine.
ArchLinux User here, Linux 4.6.3-1-ARCH #1 SMP PREEMPT Fri Jun 24 21:19:13 CEST 2016 x86_64 GNU/Linux
Can't reproduce, It seem to compile automatically to Lua 5.3.3, but even when I remove lua51 and lua52 package and THEN recompile USDX, Party Mode seem to work as expected.
Isn't the ultrastardx-git AUR installing lua51? (judging from the deps here).
I've installed the deps manually to most recent ones (since the list in the readme is a bit outdated).
From what I see, Ubuntu still uses 5.3.1, same for Debian (Jessie and wheezy). Probably only a temporary issues until derivates using the new version. Seems like a bug in 5.3.0< x <5.3.3.
It normally do, for testing purpose however I edited my local pkgbuild to not mention lua51 as a dependence.
Back when USDX Lua detection at compilation was broken, the pkgbuild applied a patch to hardcode lua51, that's why the dependence, I should probably be updating it to depend of "lua" now.
EDIT: pkgbuild was updated to depend of lua instead of lua5.1.
just tried here on ubuntu Testing + lua 5.3 and plugins still work. Can you please provide some more information on how to reproduce the issue?
5.3.x what? To reproduce, uninstall 5.3.x and force to install 5.3.1.
http://packages.ubuntu.com/search?suite=xenial&arch=i386&searchon=names&keywords=liblua
Remove 5.1 (or any other 5.3.x release). Using the packages from official sources, it'll install 5.3.1 by using:
apt-get install -s liblua5.3
Inst liblua5.3-0 (5.3.1-1ubuntu2 Ubuntu:16.04/xenial [i386]) Inst liblua5.3-dev (5.3.1-1ubuntu2 Ubuntu:16.04/xenial [i386]) Inst liblua5.3-0-dbg (5.3.1-1ubuntu2 Ubuntu:16.04/xenial [i386])
Only if I install 5.1/5.2 it works.
In Lua 5.3 LUA_INTEGER and LUA_UNSIGNED may be 64 bit types. That's why TLuaCore.PrepareState fails to modify package.searchers.
Should be fixed by 33fe22e3cfae1d67a74c0caa0ef4727027c597c3. Please test.
Issue
Running USDX and trying to open the party screen, the message "No plugins loaded" is prompted. Checking the error log file shows entries like this for every installed plugin:
The plugin dump shows the same error for every plugin:
The build is configured with the following log:
Nothing special in the make file regarding Lua.
Confirming
Uninstalling 5.3 and installing 5.1 works. Plugins are loaded.