UltraStar-Deluxe / USDX

The free and open source karaoke singing game UltraStar Deluxe, inspired by Sony SingStarâ„¢
https://usdx.eu
GNU General Public License v2.0
856 stars 161 forks source link

[Evaluation] Benefit of the import feature #69

Open RattleSN4K3 opened 8 years ago

RattleSN4K3 commented 8 years ago

Most of the users will likely don't use the import feature. Song creators may use different more convenient tools like Yass.

Do we still need the import screen or should we keep it? Should it be an hidden/activatable feature instead?

basisbit commented 8 years ago

how about either rewriting the ImportScreen or starting the external tool from that menu?

RattleSN4K3 commented 8 years ago

Not sure about that. Having it extended to feature at least the very basic stuff is the minimal goal (like creating the folder and file layout. But other than that, it cannot be as complex as other tools. External tools are nonetheless used by creator, the need to starting these from the game itself isn't ideal.

Random thought: Instead of an actual MIDI importer, it could be (additionally) a database importer (/downloader), including specifying a cover, background image and video. Downloading these on the local device and being able to directly use it (without the need of the much complex stuff_). A new song can be created on the fly without even closing the program. Could be useful for various cases.

basisbit commented 8 years ago

that will be difficult to implement because of legal issues. where do you want to get the cover images & videos from?

RattleSN4K3 commented 8 years ago

USDX won't come with anything like that. It would just implement tools to query public services/domains. Such as Cover art archive. Same for querying/using things like Youtube etc.. It's all up to the end user (and a possible EULA).

If there are things like a Youtube search isn't compatible to the license, we can still implement an interface. Similar to how the scoring web upload currently works.

basisbit commented 8 years ago

you violate the youtube API license by implementing such tools. thus any further use of youtube service is not allowed and thus you are breaking laws. this has nothing to do with the end-user.

For the score web upload we do not use any API of any service that forbids such usage.

RattleSN4K3 commented 8 years ago

I mean. This program doesn't have to embed anything or use anything third party like (and thus violating the licenses/ToS/ToU/.... We can create an interface which works with a local customly creating server/service to test such interface. Anything else doesn't have to be GPLv2 nor supported by USDX. Being open source doesn't restrict what kind of software can be used as end user (through libs, binding, etc.), it just doesn't allow being distributed (and such). A query system can be anything from a DLL, Lua/scripting language to a simple config entry (as long as the system is powerful in understanding the data). It doesn't have to be created specifically for a service (and integrated into the repo/source etc.).

And IIRC playing videos through the embed method is not violating the terms of usage. Not sure if this would work well (with buffer problems etc.).

And there are still things like OwnTube, Media Goblin, CumulusClips we could support (or base the interface on).

For the score web upload we do not use any API of any service that forbids such usage.

I meant the wep upload as example for a interface/plugin system not specifically using an API of any service.