UltraStar-Deluxe / USDX

The free and open source karaoke singing game UltraStar Deluxe, inspired by Sony SingStar™
https://usdx.eu
GNU General Public License v2.0
832 stars 160 forks source link

Release 2023.6.0 #703

Closed barbeque-squared closed 1 year ago

barbeque-squared commented 1 year ago

I can't really decide whether #700 and #701 are blockers for this or not. If not, would Friday June 2 work for whoever usually does the Mac build? (though that also has its own issues with the signing stuff now, apparently)

This is also an advance notice that unless someone else wants to do it, there probably won't be a 2023.7.0 -- or it will be more towards the end of the month, and then skip 2023.8.0. Not sure what people prefer in this regard?

Wrt the Windows FFmpeg situation: I'd say it depends on when that gets resolved:

Below the horizontal line is copy-pastable release notes, to give people a chance to comment/suggest corrections if necessary. NB: on the github release page it will just show the number without the title. on usdx.eu it will just be a plaintext number.


:rotating_light: Breaking changes

The Windows version of USDX no longer ships with DLLs for OpenSSL and cURL. Highscore plugins that rely on them should be bundled with them instead (place the plugin DLL in webs, the other DLLs in the main game directory). Although copying them over from a previous USDX version will work, it is recommended to find newer versions of the libraries the plugin depends on.

:star: Features

:chart_with_upwards_trend: Enhancements

:beetle: Bug Fixes

Other Changes

GrueneNeun commented 1 year ago

701 is not really avoidable for the user, as it crashes instantly during song selecction when pointing to the wrong song. Furthermore, all the songs i found which trigger this behaviour were automatically generated by usdb-syncer from @bohning, so the chance of this happening for other users is rather high i would say.

In any case, i would really appreciate it if this could be sorted out before a release is done. If I can contribute by testing or anything, just let me know.

barbeque-squared commented 1 year ago

Added a small bit to the letterbox feature, that users/creators of custom themes will probably want to update that element.

It's not an actual breaking change (white bars just look a bit weird) so I don't think this warrants a Breaking Changes section in a massive font. It also only affects users that use a custom theme and didn't read the release notes.

barbeque-squared commented 1 year ago

I'm fine with pushing 2023.6.0 back, since @GrueneNeun mentioned it is quite a blocker for people that use Windows with those types of videos.

GrueneNeun commented 1 year ago

Wasn't this fixed by @s09bQ5?

s09bQ5 commented 1 year ago

I have build new versions for many of our DLLs, but I lack some time to make a pull request. Maybe in a few hours.

barbeque-squared commented 1 year ago

took a while, but all the stuff should be merged now to have a working release. I haven't had time yet to update the draft release notes in the description, which I'll do tomorrow, but the most major addition is that highscore DLLs will (probably) need to be rebuilt, but I'll link to an example project. it will contain a link to this repo: https://github.com/barbeque-squared/usdx-mylittlekaraoke-windows

Unless people object, I'm also just going ahead and do the release tomorrow.

s09bQ5 commented 1 year ago

but the most major addition is that highscore DLLs will (probably) need to be rebuilt

Uh, no, they don't. People who distribute highscore DLLs now just need to also provide matching DLLs for OpenSSL and cURL, if they need them. They can take the ones from the previous releases, but they should probably try to use newer ones.

barbeque-squared commented 1 year ago

Ah fair, didn't know that. I wasn't able to reuse the My Little Karaoke one because it was missing a function, not sure which USDX version that was originally built for though.

barbeque-squared commented 1 year ago

I've updated the draft release notes in the description of this ticket. I've listed the plugin thing as a breaking change. CI is already building, will start making pages for it once there are artifacts.

barbeque-squared commented 1 year ago

Finally released (it's getting easier every time), so this ticket can be closed.

bohning commented 1 year ago

I just added the macOS dmg to the release.