this makes it so that USDX will outright refuse to load songs that rely on the current behaviour for duets where if you have sentences for P3, they'll end up in both P1 and P2. instead it will now log an error for that txt in Error.log:
ERROR: Wrong P-Number in file: "duetp3hack.txt"; Line 396 (LoadSong)
ERROR: AnalyseFile failed for "/home/bbq/gits/Ultrastar/USDX/game/songs/songs_extra_some_pony/The Count of Monte Cristo - I know those eyes/duetp3hack.txt".
this has been announced as a future breaking change in the release notes of 2024.3.0, but I don't think it'll affect that many people anyway. refusing to load it makes it so that you also can't accidentally delete the shared parts from the editor. a workaround for people that still rely on it will be provided in the next release notes, in the form of "identify duets that use P3. use 2024.3.0. open each of the identified duets in the Editor and Save. they will appear again in the newest version"
side note: P3 was actually always destructive if you saved from the editor: it would just get saved in both the P1 and P2 section.
fixes #746
this makes it so that USDX will outright refuse to load songs that rely on the current behaviour for duets where if you have sentences for P3, they'll end up in both P1 and P2. instead it will now log an error for that txt in Error.log:
this has been announced as a future breaking change in the release notes of 2024.3.0, but I don't think it'll affect that many people anyway. refusing to load it makes it so that you also can't accidentally delete the shared parts from the editor. a workaround for people that still rely on it will be provided in the next release notes, in the form of "identify duets that use P3. use 2024.3.0. open each of the identified duets in the Editor and Save. they will appear again in the newest version"
side note: P3 was actually always destructive if you saved from the editor: it would just get saved in both the P1 and P2 section.