search

UltraStar-Deluxe / USDX

The free and open source karaoke singing game UltraStar Deluxe, inspired by Sony SingStar™
https://usdx.eu
GNU General Public License v2.0
846 stars 161 forks source link

Use the cover of first song of the artist as cover for the "Artist2" Tab. #829

Closed j-lag closed 5 months ago

j-lag commented 5 months ago

When using "Artist2" and tabs, you have one tabs (folder) per Artist, with the name of the Artist but there is no cover...

This Pull Request just use the cover of the first song of the artist as cover for the artist Tab.

barbeque-squared commented 5 months ago

Can't say I ever use tabs so that took some time to figure out how those "work", but given that tabs are a feature that some people can't do without, this PR is fine.

bohning commented 5 months ago

There used to be a quite comprehensive artist cover collection that was made exactly for that use case, but many years and several laptops later, I don't have it any longer and can't recall who made it and where it was published (and of course it would never be complete, but at least the most well-known artists had a cover). So I think this is a good solution.

bohning commented 5 months ago

@j-lag Now that you are famliiar with the tabs/cover code, could you maybe look into the following?

Setting covers for language, edition, genre, year, decade etc. requires an entry in covers.ini, e.g.:

[Edition]
SingStar ABBA=.\Edition\SingStar ABBA.jpg

This is tedious. It would be great if USDX looked into the correct folder automatically for a file with a name identical to the tag value. So say a song's edition is SingStar ABBA and tabs are on with sorting by edition, USDX should look for a cover in .\Edition\SingStar ABBA.jpg (likewise in .\Genre\Rock.jpg for #GENRE:Rock) without needing an entry in config.ini. Only if the filename is different should an entry in the cover.ini be necessary. Do you understand what I mean and would that be something you could look into?

j-lag commented 5 months ago

@bohning I see what you mean but I have no icon database to test such a modification. I'm gonna work on those tabs some more because when in list mode, i want to have a scrolling list of all the songs of the selected "tab" on the right of the tab list when browsing... If you provides icons to populate editions, genre, ... I would be happy to have a look at it at the same time...

bohning commented 5 months ago

I just sent you message via mail.

j-lag commented 5 months ago

@bohning I have not received anything from you in my mail box, sorry...

bohning commented 5 months ago

@j-lag joachim.laguarda@gmail.com is correct?

j-lag commented 5 months ago

Yes

Le mer. 8 mai 2024, 22:45, Markus Böhning @.***> a écrit :

@j-lag https://github.com/j-lag @.*** is correct?

— Reply to this email directly, view it on GitHub https://github.com/UltraStar-Deluxe/USDX/pull/829#issuecomment-2101405048, or unsubscribe https://github.com/notifications/unsubscribe-auth/AC5ITU6WNTEUVAZ4IX5SPJ3ZBKFFLAVCNFSM6AAAAABG7HWHWGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMBRGQYDKMBUHA . You are receiving this because you were mentioned.Message ID: @.***>

bohning commented 5 months ago

I sent another test mail to exactly that mail address. Maybe it's in spam?