search

UltraStar-Deluxe / USDX

The free and open source karaoke singing game UltraStar Deluxe, inspired by Sony SingStar™
https://usdx.eu
GNU General Public License v2.0
846 stars 161 forks source link

Remove old Visual Studio build rules #835

Closed s09bQ5 closed 4 months ago

s09bQ5 commented 5 months ago

We don't use these files in our CI builds. The DLL is shipped prebuilt in the game/ directory.

barbeque-squared commented 5 months ago

Shouldn't the CI still try to build something for PR's? While this PR looks fine code wise, the CI has now gone completely silent, like it's not even attempting anything at all.

I expected it to show at least something referencing this PR on the History tab.

s09bQ5 commented 5 months ago

@basisbit, did you disable AppVeyor in your Github settings when you heard that the build was broken? It automatically built the remove-vcproj branch in https://github.com/s09bQ5/USDX.

basisbit commented 5 months ago

I have done nothing

s09bQ5 commented 4 months ago

This PR is not the only one that didn't trigger a CI build. It's the same for #840 and #841.

bohning commented 4 months ago

Can this be merged, @s09bQ5?