Switching from TABS=ON to TABS=OFF leads to an empty song list

UltraStar-Deluxe / USDX

The free and open source karaoke singing game UltraStar Deluxe, inspired by Sony SingStar™

https://usdx.eu

GNU General Public License v2.0

808 stars 160 forks source link

Switching from TABS=ON to TABS=OFF leads to an empty song list #836

Open bohning opened 2 months ago

bohning commented 2 months ago

Actual behaviour

When I switch TABS to off in the settings and go the song selection screen, it is empty.

Switching them back on, everything is fine:

Details

USDX version: latest head (2024-05-05)
Operating System + version: macOS Sonoma (Intel)

barbeque-squared commented 2 months ago

This is because the tab/category code is incredibly special (and I'm pretty sure also duplicated across the 7 song selection modes, but each with slight differences).

Apparently a lot of people use tabs, but I'm not one of them, so I'll leave this issue open since it is a valid bug, but unless a PR comes in, don't expect to ever see this fixed.

basisbit commented 2 months ago

I'd suggest "fixing" this by forcing the game to be restarted when leaving the settings menu after changing the tabs setting.