search

UltraStar-Deluxe / USDX

The free and open source karaoke singing game UltraStar Deluxe, inspired by Sony SingStar™
https://usdx.eu
GNU General Public License v2.0
803 stars 157 forks source link

[Windows] Changing font causes display of placeholder text for non-alphanumeric languages #839

Open odeminan opened 2 months ago

odeminan commented 2 months ago

Actual behavior

When changing the lyrics font to the other font choices, Japanese/Korean songs do not display properly and show placeholder text.

Expected behavior

Font should change as expected. Default fonts should include multiple character sets.

Steps to reproduce

  1. Open the ultrastardx.exe
  2. Tools > Options > Lyrics
  3. Change font to Free Sans.
  4. Exit option menu.
  5. Sing song with Japanese/Korean language characters in use.

Details

bohning commented 2 months ago

Free Sans simply does not contain Japanese/Korean character sets. So if you want to sing (non-romanized) Asian songs, you're (currently) stuck with Noto Sans.

odeminan commented 2 months ago

Would it make sense to check upon load of the song if the font is supported by the character set in the song? If unsupported switch to the available supported font. Or post a warning when changing the font that only some languages are supported?

bohning commented 2 months ago

Sure would make sense. Feel free to implement it and open a pull request =)