UltraStar-Deluxe / USDX

The free and open source karaoke singing game UltraStar Deluxe, inspired by Sony SingStarâ„¢
https://usdx.eu
GNU General Public License v2.0
808 stars 160 forks source link

The highest possible score is 9990 #844

Open T0nedeaf opened 2 months ago

T0nedeaf commented 2 months ago

When I hit and paint all the notes in the Easy mode, usually I get the score 9990 (in nine different songs) and only in one song (Libertango) I got 10000. Why is it so? Is it OK? It would be nice to have 10000 in all cases. I varied the number of golden notes in the *.txt files from 0 to 10, but it didn't help.

I use the v2024.3.0 version of USDX and Windows 11, Home edition 23H2.

basisbit commented 2 months ago

This is a known problem caused by USDX cutting off grading of notes which are at the ending of a sentence / line. When it switches to display the next line's notes, the audio of the last note of the previous line might not yet have arrive and be graded yet because of the delay of the audio input + output devices. This was resolved in UltraStar Play / Melody Mania by separating the grading from the sentence displaying, but doing this in USDX would be quite a bit of work.

T0nedeaf commented 2 months ago

Thank you.

T0nedeaf commented 2 months ago

Nevertheless, USDX grades some songs correctly (I know 2 such songs (out of 11)). I tried to shorten the end notes of each line in the txt files, but it didn't help. Can we fix the problem by changing something in a .txt file?