Another day, another CI fix...
This hopefully fixes the super-flaky Windows builds. I've tested that the Windows installer built in the CI with NSIS 3.05 works
Background:
As part of the Windows CI, we so far downgraded the installed NSIS version on the runner from 3.10 to 3.04, which is the version used by AppVeyor. Version 3.06 introduced a bug that made the installer crash after language selection, and a later version seemingly introduced another bug that made the installer crash even before that.
It seems like there's something going wrong with the down-grading process some of the time, as the random build failures complain about a missing function (LoadAndSetImage) that was only added in NSIS 3.05.
For now, I've tried repeating CI runs for both 3.04 and 3.05. The former led to a build failure with the aforementioned bug in 3 out of 10 runs, the latter never produced this bug at all in 17 runs so far.
In the long-term, we should probably look into finding out what goes wrong with the downgrade, or find the issue and contribute an upstream patch.
Another day, another CI fix... This hopefully fixes the super-flaky Windows builds. I've tested that the Windows installer built in the CI with NSIS 3.05 works
Background: As part of the Windows CI, we so far downgraded the installed NSIS version on the runner from 3.10 to 3.04, which is the version used by AppVeyor. Version 3.06 introduced a bug that made the installer crash after language selection, and a later version seemingly introduced another bug that made the installer crash even before that. It seems like there's something going wrong with the down-grading process some of the time, as the random build failures complain about a missing function (
LoadAndSetImage) that was only added in NSIS 3.05.For now, I've tried repeating CI runs for both 3.04 and 3.05. The former led to a build failure with the aforementioned bug in 3 out of 10 runs, the latter never produced this bug at all in 17 runs so far. In the long-term, we should probably look into finding out what goes wrong with the downgrade, or find the issue and contribute an upstream patch.