search

UltraStar-Deluxe / USDX

The free and open source karaoke singing game UltraStar Deluxe, inspired by Sony SingStar™
https://usdx.eu
GNU General Public License v2.0
856 stars 161 forks source link

No way to exit a Tab in the Song Selection. Escape / Backspace send to main menu #915

Open Travisrowe opened 3 hours ago

Travisrowe commented 3 hours ago

Actual behaviour

When Tabs are set to ON, and a tab is selected during the song selection process, the Escape / Backspace keys send the user to the main menu.

Expected behaviour

When Tabs are set to ON, and a tab is selected during the song selection process, the Escape / Backspace keys should back out of the selected tab to allow the user to select a different tab.

Steps to reproduce

Please supply step-by-step instructions so that anyone with the same environment can reproduce the issue. Whenever you offer a description, imagine yourself in the shoes of someone who has never encountered this problem before and would like to know exactly how to observe it under a given set of conditions. Here is an example:

  1. Open the ultrastardx.exe

  2. Click on button X, then on the menu that appears, click Y

  3. Wait for 3 seconds, and note the appearance of an unexpected message

  4. Open the ultrastardx.exe

  5. From the main menu, go to Tools > Options

  6. Click on Game

  7. Set Tabs to ON and Sorting to Artist

  8. From the main menu, click Sing

  9. Proceed to the Song Selection screen, then click on a tab

  10. The Escape / Backspace keys now send you to the main menu. In fact, I can't find any way to exit a tab without going back into the settings and setting Tabs to OFF

Details

Provide some additional information:

Travisrowe commented 3 hours ago

Looking at /src/screens/UScreenSong.pas:1135, I wonder if the else case on line 1162 is ultimately being hit. Just spitballing.