search

UltraStar-Deluxe / UltraStar-Creator

UltraStar Creator
GNU General Public License v2.0
29 stars 18 forks source link

preliminary work for SoundTouch BPM detection #6

Open enetheru opened 6 years ago

enetheru commented 6 years ago

removed dependency on aubio

This pull request is just so you know i'm looking into it. I will update it as i get further along.

basisbit commented 6 years ago

you might want to check the licensing stuff. I am not sure if one is allowed to use a LGPL library in a GPLv2+ application. If that actually is allowed, a link to some good explaining article would be nice 😃

enetheru commented 6 years ago

@basisbit lgpl can be used in proprietary software so long as you arent statically linking to it. if it remains a separate library you're sweet and is the entire purpose of LGPL vs GPL

https://stackoverflow.com/questions/10130143/gpl-lgpl-and-static-linking is no1 on google.

enetheru commented 6 years ago

also the QT libraries are lgplv3 so thats already happening.. :P

basisbit commented 6 years ago

the linked stackoverflow thread does not answer my question at all. UltraStar Creator is licensed under GPLv2+, SoundTech is licensed under LGPL. Please try again.

enetheru commented 6 years ago

@basisbit I'm sorry that you dont think that answer's your question. Since you are the one who is unsure please go and do the research yourself. I however, am sure that it's perfectly legal to link to an LGPL library from anywhere so long as it's only linked dynamically it will not pollute the rest of the source. the terms of ultrastars licence has zero bearing on SoundTouch's code since they do not have any dependency or link to us, that's not how licensing requirements work.

AlexanderS commented 6 years ago

https://softwareengineering.stackexchange.com/a/342158