UTF-8 encoding option missing in self compiled version from master branch (only cp1252 or cp1250 available)

UltraStar-Deluxe / UltraStar-Manager

UltraStar Manager

GNU General Public License v2.0

32 stars 18 forks source link

UTF-8 encoding option missing in self compiled version from master branch (only cp1252 or cp1250 available) #19

Closed suiluj closed 1 year ago

suiluj commented 1 year ago

Hello I noticed that the option to set the encoding default to utf8 is missing when I do a self compile for macos. (for the release version 1.8.3 I could select utf8)

I did not notice any problems for my songs (most songs I checked had working special characters and german Umlaute but I just wanted to show this:

basisbit commented 1 year ago

Using Ansi/Asci/codepages is not officially supported by UltraStar Deluxe any more. Please always use UTF-8 when saving files. As far as I know, UltraStar Manager follows that suggestion and now always saves as UTF-8, thus no need for such a dialog any more..

bohning commented 1 year ago

Exactly, I threw out the code a while ago. Everyone should finally migrate to UTF-8 =)

suiluj commented 1 year ago

Ah thanks good to know. I use utf-8 since forever so that's good news for me ;)