search

UltrosBot / Ultros-contrib

Contributed plugins, protocols and extensions for Ultros
8 stars 5 forks source link

[WoW] Item level, URL formatting, code cleanup #21

Open gdude2002 opened 10 years ago

gdude2002 commented 10 years ago

Two things from @turt2live on IRC..

Additionally, the plugin code states that a - should be used instead of a space, but this is unnecessary as command arguments wrapped in "" include the spaces within.

Manual assignee: @Zarthus - Feel free to work on this when you feel like you'll have time

turt2live commented 10 years ago

Suggested format for item level: Possible/Equipped eg: 518/518

Zarthus commented 10 years ago

I'll hopefully be able to spend some time to look into this slightly after Warlords of Draenor stabilizes.

As for the item levels (and other fancy things WoD offers), I recall the API's being harsh to work with but I did want to extend on them eventually. With the new expansion coming up I expect a few changes to their API that may break compatibility, so I think it may be best to leave this issue idle for a bit of time until Warlords of Draenor stabilizes. (I will also shortly renew my subscription for the expansion so I will have access over my own armoury characters to test with).

That said, I'm pretty occupied for the remainder of 2014, so it may take longer than desired. However, if anyone else is willing to look into this earlier, be my guest, it'd be much appreciated.

gdude2002 commented 9 years ago

Any luck, @Zarthus?

Zarthus commented 9 years ago

nope

gdude2002 commented 9 years ago

It's been ~6 months, are you still busy?

Zarthus commented 9 years ago

This just doesn't feature very high among my priorities.

gdude2002 commented 9 years ago

Sure, I get that, but it should be a ten-minute job?

Zarthus commented 9 years ago

No. I have to update the plugin for both another bot and this bot. Last time I checked it was broken so I would need to find out what changed in the API, fix the changes, implement the new features, test the changes, commit the changes, and write a pull request.

If you feel you can do it in ten minutes, feel free to do so.

gdude2002 commented 9 years ago

Ah, okay, I wasn't aware the API had broken.