UltrusBot / MobOrigins

MIT License
8 stars 18 forks source link

[Beta v1.10.0] Modify Villager Reputation doesn't seem to work as intended. #42

Closed Clark919 closed 1 year ago

Clark919 commented 1 year ago

moborigins:modify_villager_reputation does not work as shown in the example in the Wiki from what I've tested. Here is the snippet of code I am using to call the power:

"positive_renown_reputation": {
        "type": "moborigins:modify_villager_reputation",
        "modifier": {
            "operation": "addition",
            "value": 70.0
        },
        "bientity_condition": {
            "type": "origins:actor_condition",
            "condition": {
                "type": "origins:resource",
                "resource": "origination:knight/renown_renown_resource",
                "comparison": ">=",
                "compare_to": 125
            }
        }
    },

The power registers fine (it is part of origins:multiple, so ignore the incorrect syntax), and the condition is correct, with the resource active in-game. However whatever value I attempt to enter will not change the prices of Villagers whatsoever.

For further context, the only other mods I have installed that would potentially conflict with this function are Numismatic Overhaul and Liberty's Villagers, but from what I can tell their features shouldn't modify Villager Gossip.

This leads me to believe the power isn't working, unless I'm absolutely missing something.

UltrusBot commented 1 year ago

Okay, I think I've figured out the issue. The wiki has it swapped. Your power should work if its you swap the actor condition to a target condition.

Clark919 commented 1 year ago

Okay, I think I've figured out the issue. The wiki has it swapped. Your power should work if its you swap the actor condition to a target condition.

I'll give this a go when I get an opportunity and get back to you.

Clark919 commented 1 year ago

Works perfectly, thanks. Any plans to swap the Actor and Target around? Or will you just update the Wiki?

UltrusBot commented 1 year ago

I'll be updating the wiki

UltrusBot commented 1 year ago

Fixed on the wiki