search

Um-Mitternacht / Bewitchment

Mod inspired by Witchery
118 stars 69 forks source link

[Crash] Attempt to access a package private member if VanillaFix is installed #657

Closed T-Dark0 closed 3 years ago

T-Dark0 commented 4 years ago

Expected Behavior

VanillaFix's presence or absence should presumably not cause the game to fail launching

Actual Behavior

VanillaFix's "your game crashed" screen pops up (See screnshoot 1)

Steps to Reproduce

1: Install multiMC 2: Create a vanilla 1.12.2 instance 3: Add forge 4: Put Bewitchment and dependencies in the mods folder 5: Put VanillaFix there as well 6: Launch the game, and it will crash

Version of Minecraft, Bewitchment, Forge, Patchouli, and Baubles used

Minecraft: 1.12.2 Bewitchment: 1.12.2-0.0.22.40 (also tried with 1.12.2-0.0.22.39) Forge: 14.23.5.2854 Patchouli: 1.0-21 Baubles: 1.12-1.5.2

VanillaFix: 1.0.10-99

Screenshots encouraged

VanillaFix crash screen

Logs, in the event of a crash

Crash log

If this is a question, developer commentary, or a suggestion, ignore this template

NOTICE FOR TRANSLATIONS: Feuerwurm is untranslatable, and this is deliberate. It is derived from "fire" and "worm" in German, due to past names of said mob having issues with translations in some languages, mainly Romance languages. However, if your language does not use Latin characters, translate it into your equivalent of either "Fire Snake" or "Fire Worm." Yes, I'm aware Bearded Fireworms are referred to as such as in German. But you can expect those never in this mod.

T-Dark0 commented 4 years ago

Update: Downgrading VanillaFix to 1.0.7-72 seems to be a functional workaround. I haven't tested the versions between 1.0.7-72 and 1.0.10-99, however.

Should I open this issue on VanillaFix's tracker as well?

SmallEnderman commented 4 years ago

It probably has to do with mixins... If our bewitchment mixins is outdated or VanillaFix's Mixins is outdated is something i cannot see... but that seems to be one of the issues

stephen-netu commented 4 years ago

Confirmed that VanillaFix 1.0.10-150 (latest) corrects this issue.

Thank you, all!

Kira076 commented 4 years ago

This issue is not unique to Vanilla Fix. I'm having this issue as well and downgrading Bewitchment from 0.0.22.44 to 0.0.21.10 resolved it for me. I'm in Australia and it's 4 am and my brain is mush but I can provide whatever logs or further information on what mods we're using when I wake up. But it is definitely not limited to Vanilla Fix and I read in https://github.com/SpongePowered/SpongeForge/issues/3069#issuecomment-581149982 that it is a problem with anything that uses a mixin version of 0.8 or higher conflicting with ones that use the older way of doing it

Kira076 commented 4 years ago

Aha, I figured it out actually - For me it was updating JustEnoughIds... That let me upgrade to the latest bewitchment just fine