Um-Mitternacht / Bewitchment

Mod inspired by Witchery
118 stars 69 forks source link

[BUG] Blue Ink Cap not spreading #691

Closed Shazuli closed 3 years ago

Shazuli commented 3 years ago

Expected Behavior

The Blue Ink Cap whose purpose is a replacement for blue dye doesn't spread, at all. I asked around on the Discord where they explained it spreads very slowly. But from a little testing using a tickrate mod it appears like it never spreads no matter the light level.

They can be used as a blue dye, but they require a blue dye to craft it, making it completely useless. ![useless2 0](https://user-images.githubusercontent.com/9884180/103459194-a69aab80-4d0d-11eb-9475-d7c2f7bbf87b.jpg)

Actual Behavior

They should spread just like regular vanilla mushrooms, or perhaps a functionality with Bonemeal would encourage them to spread.

Steps to Reproduce

  1. Place it down on grass.
  2. Wait for heatdeath of the Universe.
  3. ???

Version of Minecraft, Bewitchment, Forge, Patchouli, and Baubles used

Mod Version
Minecraft 1.12.2
Forge 14.23.5.2854
Bewitchment 1.12.2-0.0.22.49
Baubles 1.12-1.5.2
Patchouli 1.0-20
Tickrate Changer 1.0.14

Screenshots encouraged

Screenshot of Blue Ink Cap and Brown Mushroom placed at the same time post time warp showing BIC inability to spread

2021-01-02_15 29 09

Another Blue Ink Cap placed at the same time as the other two but in sunlight

2021-01-02_15 29 17

Additional Info

I did use the vanilla randomTickSpeed gamerule too with same result. A tickrate mod would make it more fair but I thought it would be good to throw that info in too to eliminate another mod influencing the result.

Sunconure11 commented 3 years ago

I need to tweak this, then. The recipes for this is dumb. I can also probably fix the spread, too.

Sunconure11 commented 3 years ago

Got them spreading again. But nothing with bonemeal yet.

Sunconure11 commented 3 years ago

I think their spreading should make up for a lack of bonemealing. I've redone how they work and now all magical plants spread. Vanilla's logic works better than whatever we had previously.

Shazuli commented 3 years ago

Downloaded first 52 and then 53, but I don't see any plants spreading, and the recipes for some of the plants appear inconsistent. Some of them return the empty jar while other recipes don't:

plants

Sunconure11 commented 3 years ago

Which recipes are not returning jars?

Shazuli commented 3 years ago

The ones in the Gif. Frost Flower, Siphoning Flowers and Blue Ink Cap.

Sunconure11 commented 3 years ago

Fixed. About to push out another build.

Shazuli commented 3 years ago

Very nice. But it appears like the Blue Ink Caps still doesn't spread. I've sped up the world 50x for ~5 min and it still hasn't spread.

Sunconure11 commented 3 years ago

Okay, that's weird. I sped it up and they spread fine.

Sunconure11 commented 3 years ago

I had sped it up on my end to something ridiculous for testing purposes. Try higher values, perhaps?

Shazuli commented 3 years ago

Doesn't seem to do anything. Placed down regular mushrooms and they started to spread like normal.

2021-01-02_18 26 49

Sunconure11 commented 3 years ago

I think I see the issue.

Sunconure11 commented 3 years ago

Should be fixed.

Shazuli commented 3 years ago

Yup, seems to be working now:

2021-01-02_19 07 38