Um-Mitternacht / Bewitchment

Mod inspired by Witchery
118 stars 69 forks source link

[BUG] (Juniper) Broom weirdness #698

Closed Shazuli closed 3 years ago

Shazuli commented 3 years ago

Expected Behavior

When I was flying my Juniper Broom (haven't tested other brooms yet) over the water it randomly disappeared. Thought it dropped itself in the water so dived into the water and couldn't find it. Read the logs and saw these lines:

[20:07:45] [Server thread/WARN] [minecraft/Chunk]: Wrong location! (17, 64) should be (20, 47), EntityJuniperBroom['Juniper Broom'/836065, l='MagicPack2', x=276.83, y=71.16, z=1024.28]
[20:07:45] [Server thread/WARN] [minecraft/WorldServer]: Tried to add entity bewitchment:juniper_broom but it was marked as removed already

Decided to craft a new Juniper Broom and did a backup of the world to see if it would happen again, and so it did. It wrote the same warning lines again:

[21:32:47] [Server thread/WARN] [minecraft/Chunk]: Wrong location! (18, 65) should be (20, 48), EntityJuniperBroom['Juniper Broom'/10818, l='MagicPack2', x=299.29, y=87.89, z=1040.86]
[21:32:47] [Server thread/WARN] [minecraft/WorldServer]: Tried to add entity bewitchment:juniper_broom but it was marked as removed already

After a bit of testing it appears if I remove the mod Better Portals the broom no longer gets deleted when those warning logs appear, but I can no longer dismount the broom unless I reload the world. Better yet: When it didn't delete the broom I continued flying around on it. I noticed a village and saw other entities walking around like normal, and I could interact with them even if I couldn't dismount the broom. I also noticed there was no aura from the mod Thaumcraft when I tried to kill the broom entity with the Gauntlet and Foci. The Foci worked fine, but both the Gauntlet and Thaumometer both said there was none. I then flew back home, but I still couldn't dismount the broom. So I tried sleeping and that finally kicked me off the broom, but it got deleted again in the process. The aura was back to normal at my base.

Reading older issues regarding brooms it seems like the problem with no being able to dismount off of brooms is a well-known issue. So perhaps my little bug adventure could give some insight into the problem? I feel like it is a server-client desync issue. I'm guessing the brooms are rideable entities like Minecarts and Horses, but some packages are lost due to brooms being way faster than any other vanilla rideable and causes a rubber-band effect which could explain the message: Wrong location! (18, 65) should be (20, 48), Ent... from the logs.

Steps to Reproduce

Could be fairly complicated to reproduce. I think it would be best to write down every single mod I have installed (I should mention this is a singleplayer world, and not on multiplayer).

Mod Version
Minecraft 1.12.2
Akashic Tome 1.2-12
AutoRegLib 1.3-21
Baubles 1.12-1.5.2
Better Portals 0.3.7.7
Bewitchment 1.12.2-0.0.22.55
Bibliocraft 2.4.5
Bloodmoon 1.5.3
Chunk Animator 1.2
Comforts 1.12.2-1.4.1.2
Consecration 1.12.2-1.0.6
Dynamic Surroundings 1.12.2-3.6.1.0
Dynamic Trees 1.12.2-0.9.21
Dynamic Trees TC 1.12.2-1.4.2
End Portal Parallax 1.0
Gravestone Mod 1.10.3
iChunUtil 1.12.2-7.2.2
Item Scroller 0.12.0
Just Enough Items 4.16.1.301
Just Enough Resources 0.8.5
Mixin Compability 0.8
MobDismemberment 1.12.2-7.0.0
No Recipe Book 1.2.1
Optifine 1.12.2-HD-U-F5
OreLib Support Mod 1.12.2-3.6.0.1
Particle Culling 1.0.1
Patchouli 1.0-20
PeacefulSurface 1.12.2-v1b
Phosphor Lightning Engine 1.12.2-0.2.6+build50
Quark r1.6-179
Serene Seasons 1.2.18
Serene Tweaks 0.1
Shadowfacts' Forgelin 1.8.4
Smooth Font mc1.12.2-2.1.2
Sound Filters 0.12.1_for_1.12
Thaumcraft 1.12.2-6.1.BETA26
Thaumic Augmentation 1.12.2-2.0.13
ThaumicJEI 1.12.2-1.6.0-27
VanillaFix 1.0.10-150
Shazuli commented 3 years ago

Perhaps I could export the whole pack + world and add it to a Cloud service? That was you could experience the bug in a controlled environment. Just a thought if you have problems reproducing it by yourself.

Sunconure11 commented 3 years ago

Brooms are known to be bugged. We tried to fix them, many times.