Fixed various warnings/removed redundant code.

[GoogleCodeExporter]

I've built my final project setting all warnings as errors as a rule, and have 
tried to update the wsdl2objc generator to build more 'acceptable' code with 
less warnings. (For XCode 4.0.1) Then I've also run the code Analyzer on the 
generated code and fixed those warnings.

Additionally, I have also removed some (seemingly) useless leftover code here 
and there and made some minor improvements.

Please could you look at my diff file (against the current HEAD) and give me 
comments on the changes I've added.

Regards,

mariusp@labs.epiuse.com
EPI-USE Labs

Original issue reported on code.google.com by lailo...@gmail.com on 16 May 2011 at 7:48

Attachments:

• wsdlParser.diff

[GoogleCodeExporter]

Thanks for your contribution.
I can not say for the rest of the changes, but I would prefer if the 
authentication properties stay copied instead of retained:
-@property (nonatomic, copy) NSDictionary *authenticationProperties;
+@property (nonatomic, retain) NSDictionary *authenticationProperties;

This is a very small object, so copying it is no performance or memory issue.
On the other hand this will ensure that once set no one will interfere with the 
rest of the authentication logic (e.g. bugs in the rest of the application will 
not have impact on the generated code).

Regards

Original comment by pmilosev on 4 Oct 2011 at 12:05

[GoogleCodeExporter]

It may have had something to do with me altering authentication credentials 
*after* the containing object was created or something (and then propagate the 
changes that use those same credentials to other connections). But it is all a 
bit hazy now. That change was one of the less memorable for me after looking at 
the changes.

You're welcome to drop them, it is a minor change.

Original comment by lailo...@gmail.com on 5 Oct 2011 at 1:06