Feature request: The option to turn off key repeat on physical and virtual keyboard

Umang17 / softkeyboard

Automatically exported from code.google.com/p/softkeyboard

0 stars 0 forks source link

Feature request: The option to turn off key repeat on physical and virtual keyboard #185

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago

The option to turn off key repeat would be wonderful.  I haven't used
repeating keys in years, as they drive me nuts and I see no point to them
whatsoever, given  ctrl+backspace  and  select all > backspace .  I do not
know of words in any language that require the same character to be used
seven consecutive times.

Original issue reported on code.google.com by Etha...@gmail.com on 17 Nov 2009 at 7:39

GoogleCodeExporter commented 9 years ago

Original comment by menn...@gmail.com on 17 Nov 2009 at 7:51

Changed title: Feature request: The option to turn off key repeat

GoogleCodeExporter commented 9 years ago

It's for those occasions when you need to type "omgwtfbbq!!!!!!!!!!!!!!!!!!!"  
:)

Original comment by dbris...@gmail.com on 18 Nov 2009 at 5:35

GoogleCodeExporter commented 9 years ago

I agree with the creator, even that repeat key is disabled by default.. and is
optional turned on using preferences is what i would prefer...

Original comment by henrik...@gmail.com on 17 Dec 2009 at 6:39

GoogleCodeExporter commented 9 years ago

May I ?

Original comment by henrik...@gmail.com on 21 Dec 2009 at 5:58

GoogleCodeExporter commented 9 years ago

I just checked in this fix see r492, need a code review and
a an actual test on a real Device physical keyboard due to i just tested out
functionality in the emulator.

Original comment by henrik...@gmail.com on 21 Dec 2009 at 7:10

GoogleCodeExporter commented 9 years ago

So this will work ONLY on the physical keyboard, right?

Original comment by menn...@gmail.com on 21 Dec 2009 at 12:22

Changed title: Feature request: The option to turn off key repeat on physical keyboard
Changed state: Started

GoogleCodeExporter commented 9 years ago

It is confirmed that it works with the on-screen keyboard AND the hardware 
keyboard
in the emulator, it is not tested on a device with physical keyboard, but if the
emulator does it job right emulating the hardware keyboard it does work.

Original comment by henrik...@gmail.com on 21 Dec 2009 at 12:26

GoogleCodeExporter commented 9 years ago

I saw only code for the physical keyboard, not for the on-screen keyboard.

Original comment by menn...@gmail.com on 21 Dec 2009 at 12:28

GoogleCodeExporter commented 9 years ago

Hmm, hmm, now i see.. just tested on the older version and the on-screen 
keyboard
does not repeat character input.. seems to be trigged onKeyUp()

Original comment by henrik...@gmail.com on 21 Dec 2009 at 12:35

GoogleCodeExporter commented 9 years ago

Do we want keyrepeat implementation in on-screen keyb. ?? (Don't think that is 
suitable)

Original comment by henrik...@gmail.com on 21 Dec 2009 at 12:36

GoogleCodeExporter commented 9 years ago

Yes. Is should be also in the on-screen.
But the "onKeyDown" and "onKeyUp" are for the physical ONLY!
The onScreen does not invoke these functions.

Original comment by menn...@gmail.com on 21 Dec 2009 at 12:42

Changed title: Feature request: The option to turn off key repeat on physical and virtual keyboard

GoogleCodeExporter commented 9 years ago

I took the onKeyDown/Up as an aggregated implementation for both the physical 
and on
screen keyboard, but I see now... it isn't

Do you actually think it's a suitable function with key repeat on 
'on-screen-keyboard' ?

Original comment by henrik...@gmail.com on 21 Dec 2009 at 12:51

GoogleCodeExporter commented 9 years ago

What do you mean?

Original comment by menn...@gmail.com on 21 Dec 2009 at 1:08

GoogleCodeExporter commented 9 years ago

I'm going to checkin some changes for the configuration singleton, and a fix 
for the
"single time load" problem.
I'll invite you for a code review.

Original comment by menn...@gmail.com on 21 Dec 2009 at 2:14

GoogleCodeExporter commented 9 years ago

Look at r498.

Original comment by menn...@gmail.com on 21 Dec 2009 at 2:21

GoogleCodeExporter commented 9 years ago

Please test the latest:
http://softkeyboard.googlecode.com/files/anysoftkeyboard_20091222_testers.apk
Currently, this is for the physical keyboard, right Henrik?

Original comment by menn...@gmail.com on 22 Dec 2009 at 3:50

GoogleCodeExporter commented 9 years ago

http://softkeyboard.googlecode.com/files/anysoftkeyboard_20091222_2_testers.apk

Original comment by menn...@gmail.com on 22 Dec 2009 at 3:54

GoogleCodeExporter commented 9 years ago

Yes it is for the physical keyboard..

Original comment by henrik...@gmail.com on 22 Dec 2009 at 6:06