search

Umang17 / softkeyboard

Automatically exported from code.google.com/p/softkeyboard
0 stars 0 forks source link

word suggesting in hebrew is ltr instead of rtl - ON Cellcom's Galaxy device #66

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
What steps will reproduce the problem?
1. Turn auto suggestions on
2. Choose hebrew as your language 
3. When the suggestions pops up, the text is left to right, for example: 
הקידב

What is the expected output? What do you see instead?
The output should be:  בדיקה 

What version of the product are you using? On what operating system?
The latest one (from august)

Please provide any additional information below.

Original issue reported on code.google.com by tomerabr@gmail.com on 20 Aug 2009 at 12:10

GoogleCodeExporter commented 9 years ago 
Sorry for posting the exact bug 3 times. I'm posting from my phone and got an 
error... anyway, you can 
delete the duplicates. Thanks.

Original comment by tomerabr@gmail.com on 20 Aug 2009 at 12:22

GoogleCodeExporter commented 9 years ago 
Issue 68 has been merged into this issue.

Original comment by menn...@gmail.com on 20 Aug 2009 at 12:47

GoogleCodeExporter commented 9 years ago 
Issue 67 has been merged into this issue.

Original comment by menn...@gmail.com on 20 Aug 2009 at 12:47

GoogleCodeExporter commented 9 years ago 
Which phone do you have?
And which ROM?
And are you sure it is the latest from the Market?

Original comment by menn...@gmail.com on 20 Aug 2009 at 12:48

GoogleCodeExporter commented 9 years ago 

Hebrew suggestesion works great for me on latests vesrsion from the market even 
with 
user dictionery :P BUT only on software keyboard.

will it ever be avilable on hard keyboard? :)

Original comment by avicohe...@gmail.com on 24 Aug 2009 at 10:45

GoogleCodeExporter commented 9 years ago 
I haven't implemented it for the hard keyboard on purpose.
I can try to look into it.
Please open a new issue for the hard keyboard suggestions.
I'll close this one as non-issue

Original comment by menn...@gmail.com on 24 Aug 2009 at 11:48

GoogleCodeExporter commented 9 years ago 
I'm using a samsung i7500 , it's un rooted, Not sure about the ROM.
i'm pretty sure it's the latest ver.. it says 20090817-skipper

Original comment by tomerabr@gmail.com on 24 Aug 2009 at 12:16

GoogleCodeExporter commented 9 years ago 
ah!
Now I understand! You have Cellcom's Galaxy.
Right?

Original comment by menn...@gmail.com on 24 Aug 2009 at 12:19

GoogleCodeExporter commented 9 years ago 
that's right...

Original comment by tomerabr@gmail.com on 24 Aug 2009 at 12:28

GoogleCodeExporter commented 9 years ago 
This is very interesting.
Can you send me the f/w version, mod etc.
You can find it under:
Settings->"About phone" at the bottom:
Model number
Firmware version
Kernel version
Mod version
Build number

thanks

Original comment by menn...@gmail.com on 24 Aug 2009 at 12:30

GoogleCodeExporter commented 9 years ago 
Model number: Galaxy
Firmware version: 1.5
Kernel version: 2.6.27 smpark@SE-S409 #1
Build number: 76XXCSDCBALUM6375

i don't see a field called "Mod version"

Original comment by tomerabr@gmail.com on 24 Aug 2009 at 12:46

GoogleCodeExporter commented 9 years ago 
ya...
I think I'll do a little hack...

Would you like to be a tester?

Original comment by menn...@gmail.com on 24 Aug 2009 at 12:53

GoogleCodeExporter commented 9 years ago 
of course...

Original comment by tomerabr@gmail.com on 24 Aug 2009 at 12:57

GoogleCodeExporter commented 9 years ago 
[deleted comment]
GoogleCodeExporter commented 9 years ago 
[deleted comment]
GoogleCodeExporter commented 9 years ago 
Please try the attached version.

Original comment by menn...@gmail.com on 24 Aug 2009 at 5:33

Attachments:

GoogleCodeExporter commented 9 years ago 
CqCqn'

Original comment by tomerabr@gmail.com on 24 Aug 2009 at 6:05

GoogleCodeExporter commented 9 years ago 
Can't download the attachment. The link is broken.

Original comment by tomerabr@gmail.com on 24 Aug 2009 at 6:06

GoogleCodeExporter commented 9 years ago 
Please tell me if it works OK.

Original comment by menn...@gmail.com on 25 Aug 2009 at 6:44

GoogleCodeExporter commented 9 years ago 
the fix works fine, thanks!

another issue i encountered is that if there are many suggestions, clicking on 
the 
right arrow won't scroll to show them. that way, there could be suggestions 
that you 
can't choose becuase the bar seems to be un-scrollable

Original comment by tomerabr@gmail.com on 25 Aug 2009 at 6:52

GoogleCodeExporter commented 9 years ago

Original comment by menn...@gmail.com on 25 Aug 2009 at 6:55

GoogleCodeExporter commented 9 years ago 
works for on cellcom galaxy, thankyou!

Original comment by harts...@gmail.com on 5 Nov 2009 at 2:35

GoogleCodeExporter commented 9 years ago

Original comment by menn...@gmail.com on 5 Nov 2009 at 2:50

GoogleCodeExporter commented 9 years ago 
This also happened on stock Froyo when putting quotation marks around a word.

Original comment by kohe...@gmail.com on 18 Jun 2010 at 7:30

GoogleCodeExporter commented 9 years ago 
@kohen.d, Using your dibi patch for textDraw, will fix it, right?

Original comment by menn...@gmail.com on 19 Jun 2010 at 10:54

GoogleCodeExporter commented 9 years ago 
Fixes it and ruins all other completion bidi... (I am not using the version in 
this issue, yet)
Use drawChars instead of drawText and you should be OK...

Original comment by kohe...@gmail.com on 19 Jun 2010 at 11:06

GoogleCodeExporter commented 9 years ago 
?
the patched drawChars? Or Android's original drawChars?

Original comment by menn...@gmail.com on 19 Jun 2010 at 11:10

GoogleCodeExporter commented 9 years ago 
drawChars does not preform bidi processing at all by definition.
use my method (in cyanogen's framework/base/graphics/java/Canvas.java) and 
print the text itself using drawChars to avoid cases in which my patch or the 
galaxy and milestone Hebrew support causes issues.

Original comment by kohe...@gmail.com on 19 Jun 2010 at 11:14

GoogleCodeExporter commented 9 years ago

Original comment by menn...@gmail.com on 20 Jun 2010 at 1:36

GoogleCodeExporter commented 9 years ago 
@kohen.d, I took your patch and started to integrate it into ASK, but then I 
noticed I do not have access to drawChars.
All I have is a Canvas object:
http://code.google.com/p/softkeyboard/source/browse/trunk/project/src/com/menny/
android/anysoftkeyboard/CandidateView.java onDraw function.

How do I get an object which can perform drawChars (I noticed that 
AndroidGraphics2D is an internal class, so I can't use it).

Original comment by menn...@gmail.com on 30 Jun 2010 at 7:04

GoogleCodeExporter commented 9 years ago 
Since I'm working on the framework itself, I did not notice that drawChars is 
not public...

Your options are:
1. Testing for cyanogenMOD in addition to the other tests.
2. Give the user an option in tweaks (since the Arabic mod for cyanogen does 
the same)
3. Use a text.Layout object instead.

I recommend the 3rd option, I think it's the most compatible.

Original comment by kohe...@gmail.com on 30 Jun 2010 at 3:50

GoogleCodeExporter commented 9 years ago 
Try the latest RC:
http://bit.ly/a7fKVe

patch from Dudy Kohen.

Original comment by menn...@gmail.com on 7 Jul 2010 at 8:11

Attachments: