UmbraSpaceIndustries / CommunityResourcePack

The KSP Community Resource Pack
Other
50 stars 54 forks source link

Proposal: relative resource concentrations for atmospheric resources #229

Closed ChrisAdderley closed 6 years ago

ChrisAdderley commented 6 years ago

The very small concentrations of many resources in atmospheric, oceanic and exoatmospheric resource definitions are entirely impossible to harvest given that the KSP ResourceMap cannot sample values below 0.001.

This PR proposes shifting atmo, exo and oceanic distributions to relative concentrations, where 100% is now the maximum harvestable resource concentration anywhere. This has some advantages:

In addition this PR adds support for LqdDeuterium and Antimatter as resources, and modifies the distribution of LqdHydrogen somewhat.

sswelm commented 6 years ago

The problem with this proposal is that it is impossible to define a maximum density. Instead, I propose using CRP as a non linear scale below 1. I have posted the details a long time ago on the CRP discussion forum. The big advantage is that allows you to define planets atmosphere ranging from 100% to 0.000001%. Notice I have already callibrated rare resourses for helium3 lqdDeuterium and lqdHydrogen using this non linear scale.

ChrisAdderley commented 6 years ago

It's probably better to actually discuss this on the forums so that other stakeholders can participate.

BobPalmer commented 6 years ago

@ChrisAdderley - saw this was still being tweaked as of an hour ago - let me know when this is clear to merge in. Thanks!

ChrisAdderley commented 6 years ago

@BobPalmer I addressed the comments by @sswelm just now. I believe it is good to merge, I will leave the tweaking of the version (I suggest bumping the major) to you.