UmbraSpaceIndustries / Karbonite

Karbonite - Mineable. Burnable. Community-Driven.
Other
70 stars 38 forks source link

Duplicate part cleanup round 2 #263

Closed AccidentalDisassembly closed 6 years ago

AccidentalDisassembly commented 6 years ago

LF versions of the Karbonite engines also had duplicates with same part names.

MaximeBrean commented 6 years ago

Imho, both parts should be kept to prevent craft not loading. Make one of them unsearchable/unusable and mark them as deprecated would be a better option.

Also the two commit will remove the two same parts, only one should be kept (just wanted to point that).

AccidentalDisassembly commented 6 years ago

Look through the other configs - The ones I am deleting are duplicates of other config files with the same part names; there are two other part-creating cfgs in the same folder, with identical part names and nearly identical stats. Crafts will still load because there will still be this other part with the same name.

MaximeBrean commented 6 years ago

Oh my bad, I was going too fast. You're true, they are different parts. Regarding the deletion, I was confused by the fact that both duplicated parts appear in the tech tree, but not in the VAB/SPH ...