search

UmbraSpaceIndustries / MKS

MKS/OKS Colonization Systems
Other
221 stars 151 forks source link

Kerbal's KIS inventory is lost when boarding inflatable structures #1314

Open ShicKla opened 7 years ago

ShicKla commented 7 years ago

As the name implies if a Kerbal has items in his KIS inventory and boards/transfers into a module such as the 'Ranger' Workshop or Hab, that Kerbal's inventory is lost.

nagleaidan commented 7 years ago

known issue due to how KIS implements inventories and the fact that the inflatables have no crew inventory at the start (pre-inflation). current workaround is to make sure to stow all KIS parts in a container before entering an inflatable

JacobRoth commented 5 years ago

Seems this issue is still happening! Latest KSP version (1.6) and latest MKS and KIS versions off CKAN.

Goldenpsp commented 5 years ago

Seems this issue is still happening! Latest KSP version (1.6) and latest MKS and KIS versions off CKAN.

Please read all comments. This isn't a "bug". It is by design. KIS "seat inventory" isn't real inventory like a KIS container. It was implemented originally simply to allow you to give a kerbal parts at launch, since you cannot directly interact with a kerbal in the VAB/SPH. Not only will this not work with inflatable parts that have no seats when deflated, you will also "lose" inventory if you try to put KIS items in an empty seat.

menachg commented 5 years ago

the bug is not that there is no inventory the bug is that when boarding from the hatch there is no error message like when trying to transfer between parts the kis inventory just disappears and that is a bug

Goldenpsp commented 5 years ago

You may consider it a bug, but again it is a function of how "seat inventory" was implemented in KIS. So if you have an issue with this implementation take it up with THAT mod. Ultimately as I've stated before "seat inventory" was never intended as full time inventory. It was designed to give a kerbal tools in the VAB at launch. You would have the same problem if you put items into a "Seat" of a stock capsule at launch that a kerbal was not sitting in. When you went to launch you will find that seat has no items.

menachg commented 5 years ago

So the error message that there is no personall inventory is implement in kis? (Just trying to make sure i fully understand)

Goldenpsp commented 5 years ago

The issue is that "seat inventory" is not persistent storage like other kis storage. The fundamental issue in this case is that inflatable modules don't have defined seats in the same way as a capsule since they dont have seating when deflated. This is for (hopefully) obvious reasons, as you could pack kerbals in deflated modules at launch which would make no sense.

"seat inventory" has had this issue with many mods over the years as you really can't trust it. stand outside a capsule and put some tools into seat 2. then board seat 1 and you will find the tools are gone, as they only exist if someone is sitting in that seat.

The ONLY way MKS could "fix" this would be to have permanent seats in inflatable modules which isn't going to happen.

What really needs to happen is that "seat inventory" in KIS needs to be dumped and some way to track a kerbals backpack inventory needs to be implemented so it is tracked even when they enter something. but that is a KIS issue not an MKS or any other mod issue