GameData\000_USITools\Comms.cfg still misses @

UmbraSpaceIndustries / USITools

Shared components for KSP mods

Other

39 stars 38 forks source link

GameData\000_USITools\Comms.cfg still misses @ #131

Open Gordon-Dry opened 5 years ago

Gordon-Dry commented 5 years ago

Line 1: @PART[*]:HAS[!MODULE[ModuleDataTransmitter],MODULE[ModuleCommand]] should be @PART[*]:HAS[!MODULE[ModuleDataTransmitter],@MODULE[ModuleCommand]]

7ranceaddic7 commented 5 years ago

Actually, I think they have to be split up; you can't edit (@) and bang (!) within the same HAS directive ... I think.

@PART[*]:HAS[!MODULE[ModuleDataTransmitter]]:HAS[@MODULE[ModuleCommand]]

Gordon-Dry commented 5 years ago

I will test that

Gordon-Dry commented 5 years ago

Looks good

7ranceaddic7 commented 5 years ago

Just so you know, I corrected another config in the opposite direction.

Having separate :HAS directives makes MM perform and execute the processed PART TWICE. So with ...

@PART[*]:HAS[MODULE[someModule]]:HAS[MODULE[anotherModule]] { +module=whatever }

If PART has both someModule & anotherModule, whatever will be created at each instance of *Module.

But with ...

@PART[*]:HAS[MODULE[someModule,anotherModule]] { +module=whatever }

Any PART with both someModule & anotherModule will have whatever created only once.

Gordon-Dry commented 5 years ago

ofc - dunno why I overlooked that one ...

Gordon-Dry commented 5 years ago

My first one was right btw - I have seen it often and use it myself.

You misleaded me... ;)

So, @PART[*]:HAS[!MODULE[ModuleDataTransmitter],@MODULE[ModuleCommand]]

7ranceaddic7 commented 5 years ago

Yeah, looking back that would make more sense given what I said about someModule and anotherModule.