Allow discovery of logistics properties in editor

UmbraSpaceIndustries / USITools

Shared components for KSP mods

Other

39 stars 38 forks source link

Allow discovery of logistics properties in editor #46

Closed henrybauer closed 8 years ago

henrybauer commented 8 years ago

henrybauer commented 8 years ago

Names and descriptions may need some editing to be 100% accurate; I just took my best guess.

bennord commented 8 years ago

Hey Henry, I just saw that we made overlapping changes. #45 Great minds think alike, heh :)

I'm leaving my pull-request up, since my changes are a little different (added some GUI text in editor and in flight for RMB menus, and have some data visible in the info text, such as the various Range values).

Anyways, looks good and sorry we overlapped!

henrybauer commented 8 years ago

@bennord yeah looks like we submitted the same day.

You might consider a complementary change for the "Kolonization" project (for Orbital Logistics and Planetary Logistics). See https://github.com/BobPalmer/Kolonization/pull/16/files

I don't see KSPModule[] anywhere in your change - is it not required to get the green text (like "Power Distributor" and "Power Coupler")? Where is that text coming from?

bennord commented 8 years ago

@henrybauer I didn't specify them anywhere, but they were still there.

My guess is PartModule generates the default guiName from the classname by breaking it apart at the start of each capital letter, and removing "Module" from the start. Hence why all of them looked good except for the obnoxiously long USIModuleResourceWarehouse, which defaulted to "USI Module Resource Warehouse".

I went ahead and explicitly set them, using your suggestion, in my changlist as well.

BobPalmer commented 8 years ago

Had to revert this - saw it was on MASTER. Can you please re-do on DEVELOP? It already has @bennord 's changes in place