search

UmbrellaDocs / linkspector

Uncover broken links in your content.
Apache License 2.0
59 stars 8 forks source link

False positive for relative json link #12

Closed vscaiceanu-1a closed 7 months ago

vscaiceanu-1a commented 7 months ago

We have a relative link to a json file in our md and linkspector finds it as invalid.

$ linkspector check
🚫 apps/github-cascading-app/README.md, ./schemas/config.schema.json, 404, 34, Cannot find: ./schemas/config.schema.json.
❌ Error: Some links in the specified files are not valid.

The link works well, you can find it here: https://github.com/AmadeusITGroup/otter/blob/main/apps/github-cascading-app/README.md

markdown-link-check finds it valid.

FILE: apps/github-cascading-app/README.md
  [✓] https://github.com/apps/otter-cascading
  [✓] ./schemas/config.schema.json

  2 links checked.
gaurav-nelson commented 7 months ago

@vscaiceanu-1a Thank you for creating this issue. Currently, Linkspector only checks for hyperlinks, and link to a local file should have been skipped. I plan to implement local link checking sometime.

I forgot that I implemented it already. I'll get the fix in.