search

UmbrellaDocs / linkspector

Uncover broken links in your content.
Apache License 2.0
59 stars 8 forks source link

Ignoring aliveStatusCodes #16

Closed CsatariGergely closed 7 months ago

CsatariGergely commented 7 months ago

Hi, thanks for this very usefull utility. I'm in the process of building it to the GitHub workflow for the Nephio open source project. For some of the links I got a 304, what I think is still okay and should be considered as alive. I've added a config file and added 304 to the aliveStatusCodes section, but those links are still treated as error: image

gaurav-nelson commented 7 months ago

@CsatariGergely Thank you for creating the issue. Can you share more info about the screenshot? Did you run it as a GitHub action?

CsatariGergely commented 7 months ago

Thanks for the fix. Yes, I'm using linkspector from a GitHub action: https://github.com/nokia/nephio-docs/blob/add-linkcheck/.github/workflows/check-links-md.yml

CsatariGergely commented 7 months ago

@gaurav-nelson sorry I have a similar issue, but I'm not sure if this is a bug. I've set up a rule to ignore localhost links, but it seems that the config is either wrong or ignored: image

gaurav-nelson commented 6 months ago

Thank you @CsatariGergely for reporting the issue. It was a bug indeed. I also wonder why 'https://en.wikipedia.org/wiki/Don%27t_repeat_yourself` is failing 🤔