search

UmbrellaDocs / linkspector

Uncover broken links in your content.
Apache License 2.0
59 stars 8 forks source link

Add Dockerfile #23

Closed marcindulak closed 3 months ago

marcindulak commented 6 months ago

Closes #8

Focus points:

  1. Use debian instead of alpine https://martinheinz.dev/blog/92
  2. Run chrome without sandbox https://github.com/UmbrellaDocs/linkspector/discussions/11, since it is run as node user inside of the container. The tradeoff between sandboxing chrome vs giving more capabilities to the container could be reviewed later
  3. Tested (using the docker command from README.md) on Ubuntu 20.04 x86_64 and MacOS M1 arm64 (aarch64 inside of the container)
  4. bun ignored for now. It would be nice if the build could be made more reproducible (npm ci instead of npm install), while limiting the number of extra dependencies (like bun), e.g. by using package-lock.json (Done, subject to limitation https://github.com/npm/cli/issues/7224)
gaurav-nelson commented 6 months ago

Thank you @marcindulak For the PR. I'll review and merge.