The project is lacking tests

UmbrellaDocs / linkspector

Uncover broken links in your content.

Apache License 2.0

55 stars 8 forks source link

The project is lacking tests #28

Open marcindulak opened 4 months ago

marcindulak commented 4 months ago

1) ~~It may be an advantage to have some unit tests~~ Implemented in https://github.com/UmbrellaDocs/linkspector/commit/84dc8a3d218b4ed3d486c70098f208d569ff858f, more could be added. 2) A larger advantage would be to preserve the functionality of the project by having a system for running regression tests against cases (md, asciidoc, etc) submitted by users

marcindulak commented 2 months ago

Having tests could help to catch, or to verify cases like when issues are potentially closed without the feature being implemented in the expected way

https://github.com/UmbrellaDocs/linkspector/issues/25 https://github.com/UmbrellaDocs/linkspector/issues/26

gaurav-nelson commented 2 months ago

Thank you. Yup, I'm working on adding tests.

Added tests for image links and relative links

More to come.

marcindulak commented 2 months ago

https://github.com/UmbrellaDocs/linkspector/issues/26 still seems not working for me as expected with https://github.com/UmbrellaDocs/linkspector/commit/9dc2d13c83a83394b97acc06c0c4edc7e0a59137