Due to heavy dependencies (puppeteer + google chrome) the common usage of linspector will be most likely using a pre-built docker image, to minimize the risk of component installation failures, and increase the installation speed. Also pre-commit hooks will probably be of repository-local-hooks (calling a docker run) or docker_image type.
Publish docker image as umbrelladocs/linkspector. See publishing-docker-images as a starting point. Note the artifact attestation step included in the above doc. For covenience, most likely the latest explicit image tag of umbrelladocs/linkspector, e.g. v0.3.6 will be also pushed as the latest docker image tag. This will allow people who prefer to use the latest version to refer to umbrelladocs/linkspector:latest from CI systems.
Another observation: currently the docker build uses a non-standard default (requires --build-arg LINKSPECTOR_PACKAGE=) to build the image based on the local contents. This default could be changed in Dockerfile, so by default the local contents is used during the build
This is also an opportunity to reduce the confusion between potentially different 0.2.7 and v0.2.7 versions used by various services: npm, github, dockerhub.
Due to heavy dependencies (puppeteer + google chrome) the common usage of linspector will be most likely using a pre-built docker image, to minimize the risk of component installation failures, and increase the installation speed. Also pre-commit hooks will probably be of repository-local-hooks (calling a
docker run) or docker_image type.Publish docker image as
umbrelladocs/linkspector. See publishing-docker-images as a starting point. Note the artifact attestation step included in the above doc. For covenience, most likely the latest explicit image tag ofumbrelladocs/linkspector, e.g.v0.3.6will be also pushed as thelatestdocker image tag. This will allow people who prefer to use the latest version to refer toumbrelladocs/linkspector:latestfrom CI systems.Another observation: currently the docker build uses a non-standard default (requires
--build-arg LINKSPECTOR_PACKAGE=) to build the image based on the local contents. This default could be changed in Dockerfile, so by default the local contents is used during the buildwhile still support building of published npm
This is also an opportunity to reduce the confusion between potentially different
0.2.7andv0.2.7versions used by various services: npm, github, dockerhub.