UmbrellaDocs / linkspector

Uncover broken links in your content.
Apache License 2.0
55 stars 8 forks source link

Missing broken github links in markdown files #53

Closed IvanArkhipov1999 closed 1 month ago

IvanArkhipov1999 commented 1 month ago

Describe the bug I set up link checking in ci in my project. I have broken link in markdown file to file on github that doesn't exist anymore. However, linkspector says, everything is ok.

To Reproduce Steps to reproduce the behavior:

  1. This is my pet project with linkspector in ci.
  2. This is broken link in markdown file. This link.
  3. This is successful github action.

Expected behavior Linkspector shows an error in markdown file.

gaurav-nelson commented 1 month ago

Thank you @IvanArkhipov1999

In the workflow file you have reporter: github-pr-review Which means it will only report for PRs. You can confirm this by looking at https://github.com/IvanArkhipov1999/Martos/actions/runs/9150045997/job/25154355113#step:3:211

reviewdog: this is not PullRequest build.

I think you should change it to github-check which runs on both PRs and commits. See https://github.com/reviewdog/reviewdog?tab=readme-ov-file#reporters for more information.

Can you confirm what works?

IvanArkhipov1999 commented 1 month ago

Thanks for your response! I'll try it.

But I had the same problem in pull request with linkspector ci setting (https://github.com/IvanArkhipov1999/Martos/pull/46). For example, last action in this pull request https://github.com/IvanArkhipov1999/Martos/actions/runs/9150027928/job/25154316569.

GCHQDeveloper314 commented 1 month ago

I can see your pull request contains only one change adding the workflow actions file. You also don't specify a value for filter_mode. The default is added which only flags error in files that were added as part of the PR.

I also had this issue, as I was expecting problems with all existing files to be identified. For that to happen the filter_mode must be specifically set to nofilter.

IvanArkhipov1999 commented 1 month ago

Thank you for your response, that's my bad. Now it works!