Closed pz0 closed 4 years ago
@UmlautSoftwareDevelopmentAccount/adaptive-platform
What additional flags can be used here?
@pz0 any update on this?
Merging #11 into master will decrease coverage by
25.00%
. The diff coverage isn/a
.
@@ Coverage Diff @@
## master #11 +/- ##
==========================================
- Coverage 25.00% 0.00% -25.00%
==========================================
Files 2 2
Lines 4 5 +1
Branches 0 1 +1
==========================================
- Hits 1 0 -1
- Misses 3 5 +2
Impacted Files | Coverage Δ | |
---|---|---|
src/library1/lib1.hpp | 0.00% <0.00%> (-100.00%) |
:arrow_down: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 5a6cf8a...75de3e6. Read the comment docs.
@bburda
The default options are good IMO. 'warning_level=3'
and 'werror=true'
do the job. But as you said, -Wshadow
can be added.
@bburda The default options are good IMO.
'warning_level=3'
and'werror=true'
do the job. But as you said,-Wshadow
can be added.
Are you sure it is enough?
@bburda The default options are good IMO.
'warning_level=3'
and'werror=true'
do the job. But as you said,-Wshadow
can be added.Are you sure it is enough?
* warning_level 1 adds -Wall, * warning_level 2 adds warning_level 1 + -Wextra, * warning_level 3 adds warning_level 2 + -Wpedantic
My point is that default warning_level 3
together with the additional flags added here in this change are fine.
The toolchain I have gives the following flags on compilation" -Wall -Winvalid-pch -Wnon-virtual-dtor -Wextra -Wpedantic -Werror -std=c++2a -g -Wnon-virtual-dtor -Wold-style-cast -Wcast-align -Wunused -Woverloaded-virtual -Wconversion -Wsign-conversion -Wnull-dereference -Wdouble-promotion -Wformat=2 -Wmisleading-indentation -Wduplicated-cond -Wduplicated-branches -Wlogical-op -Wuseless-cast -pie -fpie -flto -fPIC
so only -Wshadow
is missing for me.
@bburda The default options are good IMO.
'warning_level=3'
and'werror=true'
do the job. But as you said,-Wshadow
can be added.Are you sure it is enough?
* warning_level 1 adds -Wall, * warning_level 2 adds warning_level 1 + -Wextra, * warning_level 3 adds warning_level 2 + -Wpedantic
My point is that default
warning_level 3
together with the additional flags added here in this change are fine. The toolchain I have gives the following flags on compilation"-Wall -Winvalid-pch -Wnon-virtual-dtor -Wextra -Wpedantic -Werror -std=c++2a -g -Wnon-virtual-dtor -Wold-style-cast -Wcast-align -Wunused -Woverloaded-virtual -Wconversion -Wsign-conversion -Wnull-dereference -Wdouble-promotion -Wformat=2 -Wmisleading-indentation -Wduplicated-cond -Wduplicated-branches -Wlogical-op -Wuseless-cast -pie -fpie -flto -fPIC
so only-Wshadow
is missing for me.
Right! Just some of them should be added through Meson built-in options https://mesonbuild.com/Builtin-options.html#base-options (lto and pie for sure)
@bburda The default options are good IMO.
'warning_level=3'
and'werror=true'
do the job. But as you said,-Wshadow
can be added.Are you sure it is enough?
* warning_level 1 adds -Wall, * warning_level 2 adds warning_level 1 + -Wextra, * warning_level 3 adds warning_level 2 + -Wpedantic
My point is that default
warning_level 3
together with the additional flags added here in this change are fine. The toolchain I have gives the following flags on compilation"-Wall -Winvalid-pch -Wnon-virtual-dtor -Wextra -Wpedantic -Werror -std=c++2a -g -Wnon-virtual-dtor -Wold-style-cast -Wcast-align -Wunused -Woverloaded-virtual -Wconversion -Wsign-conversion -Wnull-dereference -Wdouble-promotion -Wformat=2 -Wmisleading-indentation -Wduplicated-cond -Wduplicated-branches -Wlogical-op -Wuseless-cast -pie -fpie -flto -fPIC
so only-Wshadow
is missing for me.Right! Just some of them should be added through Meson built-in options https://mesonbuild.com/Builtin-options.html#base-options (lto and pie for sure)
Ah, ok, I see. Sure, I didn't notice Meson already has b_lto
and b_pie
.
I added few gcc flags to meson.build file. Do you have any suggestions about flags?