space-Travellers

[Umuhan]

Hi Code Reviewer.

Below is the link to our GitHub project.

• We are two people in this project

https://github.com/Umuhan/space-Travellers/projects?type=classic

[Omar-Muhamad]

Changes Required ♻️

Hi @,

Nice job, you are almost there.

(Changes Required) Aspects to improve: ♻️

• [ ] As per this requirement, Please make sure that all Kanban cards are assigned to team members, for example there are cards meant to team member A and others meant to team member B and for group tasks you can assign both of you to it.

This is your cards:

and this is how suppose to be:

• [ ] For a team with two people, the number of cards in Backlog should be equal to 17, not 15 as you did, Please add the 2 missing cards.

[Optional] suggestions:

• Nothing to mention.

Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear, and please remember to tag me in your question so I can receive the notification**

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.

---

As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

[skyv26]

Hi @Umuhan and @hamzaw9,

Great work on making the changes requested by a previous reviewer 👏 You've done well implementing some of the requested changes, but there are still some which aren't addressed yet.

STATUS: REQUIRE CHANGES 🔴

Highlights

• N/A

Required Changes ♻️

• [ ] Please follow the things properly, as your previous code reviewer already mentioned that you are a team of two people and your Kanban board should contain a 17 task instead of 15, which means you are supposed to add 2 missing cards. But it seems like, you only implemented the one change and did not add the the missing cards. Kindly add the two missing cards in order to get the approval for the project setup.

The two missing cards are related to fetching the mission and rockets. Please take a look at the below screenshot

Check the comments under the review.

Cheers, and Happy coding!👏👏👏

Have any doubt ❓

Please, remember to tag @skyv26 in your question so I can receive the notification. You can also follow me on the below platforms

---

As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

[ridwanediallo]

STATUS: APPROVED 🟢

Hi :wave: team,

Your project is complete! There is nothing else to say other than... it's time to merge it :shipit: Congratulations! 🎉

(Highlights) Good Points: :+1:

• You documented your work professionally. ✔
• Well done adding the missing cards. 🎉 🎉 🎉 ✔

Optional suggestions

Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear. Please, remember to tag me in your question so I can receive the notification.

---

As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.