users and groups page visual debt - Githubissues

Umuzi-org / Tilde

Open source agile, collaborative learning platform.

52 stars 34 forks source link

users and groups page visual debt #634

Closed TheMaja closed 1 year ago

TheMaja commented 2 years ago

initial commit
whitespace between buttons + next to buttons added
added whitespace around filter text fields
Scrolling behavior: keeps the filters in view and scrolls the rest

Related issues: [please specify]

Description:

What are you up to? Fill us in :)

Screenshots/videos

visual debt removed

I solemnly swear that:

[x] My code follows the style guidelines of this project
[x] I have merged the develop branch into my branch and fixed any merge conflicts
[x] I have performed a self-review of my own code
[ ] I have commented my code in hard-to-understand areas
[x] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes

TheMaja commented 1 year ago

This looks good @TheMaja . Please address the review talking about responsiveness: #634 (review)

The page isn't mobile friendly:

This page won't be frequently used for mobile that's not necessary, remember the discussion we had on sprint review.