Umuzi-org / Tilde

Open source agile, collaborative learning platform.
52 stars 34 forks source link

windows configuration #670

Closed minat-hub closed 6 months ago

minat-hub commented 9 months ago

Related issues: The automarker wasnt running well on windows because the initial configuration was for unix(mac and linux) os

Description:

I updated the steps.py so that if the os that automarker is running on is Unix it uses the existing command and if the os is windows it uses command that is compatible for windows

Screenshots/videos

I solemnly swear that:

minat-hub commented 9 months ago

There were some issues I noticed while I was trying to help Mpho set up his environment where some commands like "cp" and "mv" or "rm" weren't working. Do we have that covered here or there was something I did wrong

Hello Percival, thank you for pointing that out. These issues were resolved by either using git bash terminal or ubuntu windows subsystem for linux terminal instead of powershell . It was because the automaker was being run on windows powershell. I was thinking along the lines of adding in the Readme that windows users should use the git bash or windows subsystem to run the automarker. Should i do this or include the equivalent commands for windows instead?

kingraphaii commented 9 months ago

Should i do this or include the equivalent commands for windows instead?

If we can make it work with command prompt or powershell, I think it'll be a proper windows implementation, we can resort to git bash/cygwin if the cmd/powershell approach does not work

minat-hub commented 7 months ago

If we can make it work with command prompt or powershell, I think it'll be a proper windows implementation, we can resort to git bash/cygwin if the cmd/powershell approach does not work

Hello Percival, I updated all the commands for automarker for powershell terminal but some of them doesnt work for command prompt so that means some of these commands had to be updated for it too. This wasn't a very efficient approach as it made the code bulky. Some of the linux command when converted to PowerShell also behaved slightly differently. I opened a pr to inform windows users to use git bash/cygwin. What do you think?

kingraphaii commented 7 months ago

What do you think?

I think that is OK if it works! Everyone who needs to use it should have git anyway so it's highly likely they have git-bash