display all reviewers on agile card

TheMaja commented 3 months ago

Description:

Displaying all the card reviewers in a dropdown

https://github.com/Umuzi-org/Tilde/assets/37469171/fb61f7ad-b6f9-4a63-b94e-4bcf7374d612

I solemnly swear that:

[x] My code follows the style guidelines of this project
[x] I have merged the develop branch into my branch and fixed any merge conflicts
[x] I have performed a self-review of my own code
[x] I have commented my code in hard-to-understand areas
[x] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[x] I have tested new or existing tests and made sure that they pass

Sbonelo01 commented 3 months ago

@TheMaja I also mentioned that I get the same error that @Ngoakor12 stated. Can I take over this task as per @sheenarbw 's suggestion on MoM? I'll create a different branch but I'll take some of the code you've written so it does not go to waste.

TheMaja commented 3 months ago

@TheMaja I also mentioned that I get the same error that @Ngoakor12 stated. Can I take over this task as per @sheenarbw 's suggestion on MoM? I'll create a different branch but I'll take some of the code you've written so it does not go to waste.

issue resolved had to do with my branch being outdated

TheMaja commented 3 months ago

@TheMaja I also mentioned that I get the same error that @Ngoakor12 stated. Can I take over this task as per @sheenarbw 's suggestion on MoM? I'll create a different branch but I'll take some of the code you've written so it does not go to waste.

Issue resolved. It had to do with my branch being outdated. @Sbonelo01 resolved okay you will take over after it has been merged or if issues are raised afterwards by @sheenarbw

Ngoakor12 commented 3 months ago

I'm also in favour of @Sbonelo01 taking over, as was suggested before.

Sbonelo01 commented 2 months ago

@Ngoakor12 , I replaced the hover with a click. I did this to make it more intentional to see all the reviewers. Hovering over something could mean anything

Ngoakor12 commented 2 months ago

I found a good example regarding my first point above: It's the activity log on mom

Sbonelo01 commented 2 months ago

Points addressed. Side note noted 👍🏿

https://github.com/Umuzi-org/Tilde/assets/37469171/a66337df-cf89-4f6d-b5a0-bfd9a613df8c

Sbonelo01 commented 1 month ago

[x] Close icon matches this PR
[x] I think I remember Sheena saying the avatars should be in the drop-down. I've kept them there
[x] Width of the drop-down is no longer contained to the width of the card, but contained to the width of the column

kingraphaii commented 1 month ago

Looks better, but with longer emails, its not looking good. Will pass it to @Ngoakor12

Sbonelo01 commented 1 month ago

Looks much better

[x] I think I remember Sheena saying the avatars should be in the drop-down. I've kept them there

I disagree, mainly because I don't remember the reason for keeping them. But I'll leave that for Sheena to decide.

I believe you should open a PR branching out from develop since this is pulling from develop_without_sheena and that one already had a bunch of things merged that not apart of the develop branch yet

You'll pass it on to Sheena once you have the branches sorted

Regarding Avatars. See Sheena's message to Themba in this update reply: https://umuzi-projects.monday.com/boards/1274815998/pulses/1387241235/posts/214035695

I will update the branches

Umuzi-org / Tilde

display all reviewers on agile card #724

Description:

I solemnly swear that: