Add review modal - Githubissues

Umuzi-org / Tilde

Open source agile, collaborative learning platform.

52 stars 34 forks source link

Add review modal #751

Closed kingraphaii closed 1 month ago

kingraphaii commented 1 month ago

Related issues: [please specify]

Description:

What are you up to? Fill us in :)

Screenshots/videos

I solemnly swear that:

[x] My code follows the style guidelines of this project
[x] I have merged the develop branch into my branch and fixed any merge conflicts
[x] I have performed a self-review of my own code
[x] I have commented my code in hard-to-understand areas
[x] My changes generate no new warnings
[x] I have added tests that prove my fix is effective or that my feature works
[x] I have tested new or existing tests and made sure that they pass

Ngoakor12 commented 1 month ago

Previous feedback

kingraphaii commented 1 month ago

The reviews seem to be floating around, is there a way to make it a bit more consistent with the rest of the content on there? So maybe make use of borders to group the reviews or anything else that can make them look less out of place?

Done

The list of reviews also doesn't show any of the reviews

I removed some of this to keep the PR lean, old PR was 3 tasks in 1, so this is more focused on adding reviews only. The other two are dependant on this one.

The list is also nowhere to be found once I refresh

See previous point

kingraphaii commented 1 month ago

If this PR is just for the form/modal, then:

the recently added review doesn't need to show up because the one that shows is missing the actual comment

As per: If you use a modal to display the form then please use alpinejs And once the form is submitted then the new review should show up.

the review container can be removed, plus it shows up in topics too which is weird

I have fixed it to only show for projects