UnBCIC-TP2 / Oberon-Scala

An implementation of the Oberon language using Scala

55 stars 118 forks source link

Type check core #98

Closed delanoerhardt closed 2 years ago

delanoerhardt commented 2 years ago

Changes

The type checker now doesn't stop if an error is found in the condition of a conditional statement

delanoerhardt commented 2 years ago

We should discuss this PR. Our design here is to deal with errors using a list. The empty list means that no error has been found. A list with at least one element means that the program has at least one type error. Why should we stop in the first error found?

This is exactly what the PR fixed! Sorry for the miscommunication, I rewrote the description to try to make it clearer.

rbonifacio commented 2 years ago

excellent contribution! I really enjoyed the method simplifications in this PR (such as the one in visitIfElseIfStmt)