UnPourTous / react-native-search-list

A searchable ListView which supports Chinese PinYin and alphabetical index.

159 stars 66 forks source link

Closed zanechua closed 3 years ago

zanechua commented 4 years ago

The aim of this PR is to remove deprecated components inside this package to make it compatible with 0.6x and above.

I've also included some improvements in terms of being able to set styling for additional elements and being able to hide the toolbar.

Resolves:

18

zanechua commented 4 years ago

I probably need to refactor this to revert the README itself. Will add in another commit to revert the README.

erichua23 commented 4 years ago

Perfect work!! but I tried your code, the demo does not works.

by the way, changing the code style to match standardjs as before is better.

zanechua commented 4 years ago

Thanks for testing it.

Yeah. I think I broke the demo initially but didn't have time to go back and fix it. I can take a look at it and fix it I think.

Sure! I used semistandard because that's what I was using in my project but it's easy to switch back. Just a lint. :)

I'll rework this a little bit!