UnUniFi / utils

10 stars 2 forks source link

v0.45.1 support for /ununifi/cdp/cdps #241

Closed Senna46 closed 2 years ago

Senna46 commented 2 years ago

close #232 #233 Support for displaying CDP in multiple Denom.

Changes

To do

Testing of each function

スクリーンショット 2022-03-30 150451 スクリーンショット 2022-03-30 150524

Senna46 commented 2 years ago

@YasunoriMATSUOKA Wow, I forgot. /ununifi/cdp/cdps didn't get Deposit. i'll fix it.

Senna46 commented 2 years ago

What would be the original value? So, the getWithdrawLimit() needs to be modified.

Solved! Forget it plz.

YasunoriMATSUOKA commented 2 years ago

If you finish fixing, can you show me screenshot?

Senna46 commented 2 years ago

Available collateral tokens was fixed, View Deposit is currently being fixed.

VM1526:1          GET http://a.private-test.ununifi.cauchye.net:1317/ununifi/cdp/deposits/owners/ununifi1ptskrqeh7jye5z062dpt9pcsr2evn3nx38cgg0/collateral-types/ubtc-jpy-3-2 404 (Not Found)

スクリーンショット 2022-03-30 153702

YasunoriMATSUOKA commented 2 years ago

Thank you for your fix. But now, principal issue available limit seems to be abnormal. Can you fix it as well?

image

For deposit, it is OK to put it off as a low priority. Because the API seems to be unable to return normal values from previous versions.

Senna46 commented 2 years ago

Fixed as well.

I think so too. Looks like we need to modify the API. スクリーンショット 2022-03-30 154608

Senna46 commented 2 years ago

Work

deposit, withdraw

Doesn't work(Denom Problem)

issue, clear

i will start working.

Senna46 commented 2 years ago

@YasunoriMATSUOKA I don't have merge authority, so please do it.

YasunoriMATSUOKA commented 2 years ago

I think you need to debug deposit limit and withdraw limit. Firstly, check them plz. I will merge this PR now, so plz wait a moment