search

UnaNancyOwen / VelodyneCapture

VelodyneCapture is the general capture class to retrieve the laser data from Velodyne sensors using Boost.Asio and PCAP
MIT License
54 stars 21 forks source link

Pr09042018 #23

Closed lasdasdas closed 6 years ago

lasdasdas commented 6 years ago

Hi @UnaNancyOwen ,

As discussed ages ago, this PR contains a preprocessor macro to enable gps time instead of unix time. Still data packet precision ( no shooting delay LUT for now, but this will eventually be implemented) . I have also completed the CMakeList.txt of both examples to consider this macro.

The build is kinda messed up, I had to add a bit more of code to make FindPCAP work in Linux. If you had a minute to check that the build still works on Windows it would be great (although I am pretty certain it still does).

UnaNancyOwen commented 6 years ago

Thanks, Looks good to me about code of GPS time. But, I'm surprised that necessary add this changes (aef0a40) to FindPCAP.cmake for case of Linux. I hope to keep it simple. Can you make it more simpler?

lasdasdas commented 6 years ago

Ok. I'll see what I can do.

lasdasdas commented 6 years ago

Check it now, it's much much cleaner. The ${PCAP_LIBRARY_DIR} variable is messing with my builds on linux. I had to put the find_package_handle_standard_arg() so that it only gets sourced if ISFOUND.

UnaNancyOwen commented 6 years ago

Good! 👍 If you want it, I think that it is good to remove PCAP_LIBRARY_DIR. It is not always necessary.

lasdasdas commented 6 years ago

Should I remove It then? Is it necessary in any case? I'll commit the changes in a second.

lasdasdas commented 6 years ago

Is this what you mean?

UnaNancyOwen commented 6 years ago

Yes. On more, Please remove PCAP_LIBRARY_DIR from CMakeLists.txt of samples.

lasdasdas commented 6 years ago

I just did it

UnaNancyOwen commented 6 years ago

LGTM👍